only public symbols for spidermonkey in breakpad since 12/14

RESOLVED FIXED in mozilla1.9

Status

RESOLVED FIXED
11 years ago
8 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
mozilla1.9
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Seems likely to be:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/js/src&command=DIFF_FRAMESET&file=Makefile.in&rev1=3.113&rev2=3.114&root=/cvsroot

Must be some bustage using MODULE_OPTIMIZE_FLAGS. I think I recall seeing sqlite missing symbols as well, which would make sense.
Assignee: nobody → ted.mielczarek
Depends on: 407794
Ok, tracked this down with timeless' help. Turns out my change here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=config.mk&branch=&root=/cvsroot&subdir=/mozilla/config&command=DIFF_FRAMESET&rev1=3.383&rev2=3.384

broke this in a different way, since I don't set OS_CFLAGS. The old code didn't work either, since it set MOZ_OPTIMIZE_FLAGS, which wouldn't get used if you set MODULE_OPTIMIZE_FLAGS. Easy patch though!
Created attachment 307094 [details] [diff] [review]
set CFLAGS too [checked in]

Yeah, this fixes it.
Attachment #307094 - Flags: review?(benjamin)
Comment on attachment 307094 [details] [diff] [review]
set CFLAGS too [checked in]

I checked this in to get good symbols in JS again for nightlies. I'm considering it a bustage fix (for long-standing bustage). Requesting post-hoc review/approval.
Attachment #307094 - Attachment description: set CFLAGS too → set CFLAGS too [checked in]
Attachment #307094 - Flags: approval1.9?
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Flags: blocking1.9?
Target Milestone: --- → mozilla1.9

Updated

11 years ago
Attachment #307094 - Flags: review?(benjamin) → review+

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.