Closed Bug 420759 Opened 12 years ago Closed 12 years ago
only public symbols for spidermonkey in breakpad since 12/14
The nightly on 12/13 has full symbols, the nightly on 12/14 has only public symbols. I think this was from twiddling optimization flags: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-12-13+04%3A00%3A00&maxdate=2007-12-14+05%3A00%3A00&cvsroot=%2Fcvsroot
Symbols from the 13th: http://symbols.mozilla.org/firefox/js3250.pdb/6B512C21AD364422937E862CEF68C7E46/js3250.sym Symbols from the 14th: http://symbols.mozilla.org/firefox/js3250.pdb/03D04A15DAEA42C59B3B68E4E0402B911/js3250.sym
Seems likely to be: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/js/src&command=DIFF_FRAMESET&file=Makefile.in&rev1=3.113&rev2=3.114&root=/cvsroot Must be some bustage using MODULE_OPTIMIZE_FLAGS. I think I recall seeing sqlite missing symbols as well, which would make sense.
Assignee: nobody → ted.mielczarek
Ok, tracked this down with timeless' help. Turns out my change here: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=config.mk&branch=&root=/cvsroot&subdir=/mozilla/config&command=DIFF_FRAMESET&rev1=3.383&rev2=3.384 broke this in a different way, since I don't set OS_CFLAGS. The old code didn't work either, since it set MOZ_OPTIMIZE_FLAGS, which wouldn't get used if you set MODULE_OPTIMIZE_FLAGS. Easy patch though!
Yeah, this fixes it.
Attachment #307094 - Flags: review?(benjamin)
Comment on attachment 307094 [details] [diff] [review] set CFLAGS too [checked in] I checked this in to get good symbols in JS again for nightlies. I'm considering it a bustage fix (for long-standing bustage). Requesting post-hoc review/approval.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.