Closed Bug 420776 Opened 16 years ago Closed 11 years ago

ASSERTION: Fastload file should have been closed via xpcom-shutdown

Categories

(Core :: XPCOM, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: coop, Unassigned)

Details

Attachments

(1 file)

Hitting the following assertion on Centos 5 and MacOSX when running 'make check' against debug builds with bloat and leak logging enabled:

ASSERTION: Fastload file should have been closed via xpcom-shutdown: '!mFastLoadTimer', file /builds/slave_leaktest/trunk_centos5/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp, line 487

Full CentOS log:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1204525817.1204540958.26158.gz&fulltext=1#err0

Full MaxOSX log:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1204572792.1204582399.313.gz&fulltext=1#err0

Shorter context at:
http://wiki.mozilla.org/User:ChrisCooper:UnittestingLeakAnalysis
Brendan, what's up here?
Component: XPConnect → XPCOM
QA Contact: xpconnect → xpcom
Something leaked? I forget the details of how Ben reworked fastload shutdown, but IIRC it's like fat ref-counting -- when a hashtable goes empty, things close. So why is the hashtable not going empty? Someone needs to debug.

Damon, can you help get this bug an owner?

/be
(In reply to comment #2)
 
> Damon, can you help get this bug an owner?
> 
> /be
> 

I'll see who I can find.  Also, blocker?
Flags: blocking1.9?
Version: unspecified → Trunk
Haven't seen any motion and unsure of impact - taking off nom list..
Flags: blocking1.9? → blocking1.9-
Attached file stack
i was running into this assertion and Leak also during JS Tests on Mac 10.5.5 and a Gobal 500 Top Site Run on Windows with a new 1.9.1 Test Build.

Leak Log:

== BloatView: ALL (cumulative) LEAK STATISTICS

     |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
                                              Per-Inst   Leaked    Total      Rem      Mean       StdDev     Total      Rem      Mean       StdDev
   0 TOTAL                                          31     6218   134368      202 (  464.25 +/-   654.60)   234326      200 (  326.01 +/-   709.66)
   2 BackstagePass                                  24       24        1        1 (    1.00 +/-     0.00)     2974        2 (   49.02 +/-    17.62)
  60 StringAdopt                                     1        2     1308        2 (   68.40 +/-    29.00)        0        0 (    0.00 +/-     0.00)
  63 ThreadShutdownObserver                         16       16        1        1 (    1.00 +/-     0.00)        4        1 (    1.71 +/-     0.76)
  76 XPCNativeScriptableShared                     108      108      558        1 (   15.06 +/-     9.10)        0        0 (    0.00 +/-     0.00)
  79 XPCWrappedNative                               56      336     1246        6 (  457.12 +/-   216.38)     8915        6 (  515.00 +/-   207.74)
  80 XPCWrappedNativeProto                          28       56      236        2 (   98.23 +/-    47.29)        0        0 (    0.00 +/-     0.00)
 100 mozStorageConnection                           76       76        4        1 (    2.29 +/-     1.11)      157       33 (   60.44 +/-    30.49)
 101 mozStorageFunctionGetUnreversedHost            12       12        1        1 (    1.00 +/-     0.00)        1        1 (    1.00 +/-     0.00)
 102 mozStorageService                              28       28        1        1 (    1.00 +/-     0.00)       20        1 (    4.41 +/-     1.96)
 103 mozStorageStatement                            44     1408      121       32 (   56.80 +/-    28.73)      283       32 (   56.66 +/-    28.03)
 107 nsAnnotationService                            84       84        1        1 (    1.00 +/-     0.00)        9        1 (    2.41 +/-     1.18)
 119 nsBaseAppShell                                 64       64        1        1 (    1.00 +/-     0.00)     1499        1 (    7.45 +/-     1.21)
 125 nsBaseURLParser                                12       12        3        1 (    1.80 +/-     0.84)     2575        1 (  188.72 +/-   104.73)
 190 nsCategoryObserver                             60       60        2        1 (    1.33 +/-     0.58)       73        1 (   10.17 +/-     2.35)
 225 nsDNSService                                   44       44        1        1 (    1.00 +/-     0.00)       11        1 (    5.19 +/-     2.46)
 353 nsIDNService                                   64       64        1        1 (    1.00 +/-     0.00)       21        1 (    2.80 +/-     1.40)
 355 nsIOService                                   124      124        1        1 (    1.00 +/-     0.00)     1585        1 (    6.21 +/-     1.37)
 390 nsLocalFile                                    88       88     2137        1 (  219.19 +/-   115.83)    12202        1 (  256.76 +/-   135.34)
 407 nsNavBookmarks                                192      192        1        1 (    1.00 +/-     0.00)       17        2 (    4.31 +/-     1.65)
 415 nsNotifyAddrListener                          180      180        1        1 (    1.00 +/-     0.00)        8        1 (    3.33 +/-     1.35)
 421 nsObserverService                              48       48        1        1 (    1.00 +/-     0.00)      476        1 (   13.54 +/-     6.22)
 437 nsPrefBranch                                   56       56       19        1 (    8.19 +/-     4.87)      110        1 (   13.93 +/-     7.95)
 457 nsRunnable                                     12       12      247        1 (   27.26 +/-    32.80)      797        1 (   26.61 +/-    32.14)
 482 nsSocketTransportService                     1676     1676        1        1 (    1.00 +/-     0.00)       51        1 (    6.27 +/-     1.93)
 484 nsStandardURL                                 176      176      670        1 (  188.12 +/-   105.04)     8392        2 (  416.78 +/-   211.88)
 491 nsStringBuffer                                  8      696    12679       87 ( 1789.39 +/-  1205.65)    22011       88 ( 2023.17 +/-  1344.84)
 492 nsStringBundle                                 36       36       12        1 (    6.26 +/-     3.40)       75        1 (   10.28 +/-     5.47)
 506 nsSystemPrincipal                              36       36        1        1 (    1.00 +/-     0.00)     6004        1 (   83.00 +/-    74.53)
 507 nsTArray_base                                   4        4     9582        1 ( 1101.99 +/-   273.88)        0        0 (    0.00 +/-     0.00)
 524 nsThread                                       72       72       11        1 (    5.00 +/-     2.26)     2996        6 (  501.51 +/-   221.90)
 525 nsThreadPool                                   60       60        3        1 (    1.80 +/-     0.84)       23        1 (    4.47 +/-     1.87)
 544 nsUnicodeNormalizer                            12       12        1        1 (    1.00 +/-     0.00)        4        1 (    1.71 +/-     0.76)
 557 nsVoidArray                                     4      152     3061       38 (  727.87 +/-   276.15)        0        0 (    0.00 +/-     0.00)
 559 nsWeakReference                                16       80      126        5 (   59.58 +/-    31.28)      792        5 (  141.75 +/-    83.26)
 606 nsXPCWrappedJS                                 60       60       74        1 (   32.82 +/-    17.07)      932        2 (   86.87 +/-    40.74)
 607 nsXPCWrappedJSClass                            44       44       19        1 (    7.49 +/-     3.76)      561        1 (   42.22 +/-    17.21)
 633 xptiInterfaceInfo                              20       20     1223        1 (  152.95 +/-   117.34)     6873        1 (  290.16 +/-   154.01)

nsTraceRefcntImpl::DumpStatistics: 635 entries
nsStringStats
 => mAllocCount:          12084
 => mReallocCount:          595
 => mFreeCount:           11997  --  LEAKED 87 !!!
 => mShareCount:           9332
 => mAdoptCount:           1308
 => mAdoptFreeCount:       1306  --  LEAKED 2 !!!
Flags: wanted1.9.1?
See also bug Bug 587263, a new instance of this assertion cropping up on tinderbox.
Bug 520309 removed the assertion:
https://hg.mozilla.org/mozilla-central/rev/78e8c3514fff
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: