420814 - selector "A ~ B C" matches greedily instead of nondeterministically

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: simplified testcase

This was found in test 42 on acid3.  Selectors of the form "A ~ B C" match greedily when they should be nondeterministic.  Patch should be trivial.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 307169 [details] [diff] [review]
patch

>+<p id="display"><iframe id="iframe" src="empty.html"></iframe></p>

Why not just leave off the src attribute and test in the about:blank document?

Either way, run the test off a load event?

r+sr=bzbarsky with that.

Comment 3

[mdew]

tested and works, and parity with opera.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This addresses Boris's review comments.

As to why I was working on this in the first place: I was scared that the failure of test 42 on acid3 meant something was fundamentally wrong with the patch I wrote a few weeks ago.  Once I figured out that that wasn't the case, this was trivial to fix.  Low risk, gets us another point on acid3.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307172 [details] [diff] [review]
patch

a1.9=beltzner

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk, 2008-03-05 16:06 -0800.

Comment 7

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008030704 Minefield/3.0b5pre, using the test case in the bug.