420856 - All tabs button no longer provides feedback when new tab is opened after overflow

Status: RESOLVED DUPLICATE of bug 409523

(Firefox :: Theme, defect)

Description

[Michael Ventnor]

On Firefox 2 we used to have an orange glow effect on the all tabs button when we opened a new tab in the background, and it ended up offscreen due to overflow. This was lost when we switched to native tabs. We can bring back and even exceed this effect in terms of nativeness, by using the CSS old faithful: Highlight.

I found the border will make it slightly more noticeable, the border radius is just for general niceness.

Comment 1

[Michael Ventnor]

Attachment: Patch

Boo at Bugzilla for losing my patch the first time.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Is this the wrong patch? Why do you need the XBL?

Comment 3

[Michael Ventnor]

(In reply to comment #2)
> Is this the wrong patch? Why do you need the XBL?
> 

I needed to provide a stack with the fading hbox underneath everything else; in this case the dropmarker. If I just made it a child without this XBL the hbox would completely push the dropmarker to zero width and we'd have a button with nothing in it.

Of course I can't just move the hbox into the XBL, the animation javascript in tabbrowser.xml wouldn't see it.

Should have explained this in the first comment.

Comment 4

[Michael Ventnor]

I'm actually wondering if there's a better way to do this. Putting some platform-specific XBL in the theme puts a lot of pressure on theme creators especially at this stage.

Comment 5

[Mike Connor [:mconnor]]

Already minused, would take a safe and non-invasive patch if one shows up on the original bug.