Closed
Bug 421005
Opened 16 years ago
Closed 16 years ago
FUEL: undefined this._prefs when calling Preferences.type
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 beta5
People
(Reporter: u278084, Assigned: mfinkle)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
5.01 KB,
patch
|
Gavin
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
When you do something like
Application.prefs.get("network.proxy.type").type
from javascript, an exception is thrown because this._prefs is undefined in Preferences object. See above url for exact location this error occurs. It probably needs to get this.branch._prefs
The fix is trivial, but I'm doing this as (lame) practice for doing mochitests. Also, if you had it in there, I wouldn't have to file this bug ;)
Summary: FUEL: undefined this._prefs when callling Prefences.type → FUEL: undefined this._prefs when calling Prefences.type
|
||
Updated•16 years ago
|
Summary: FUEL: undefined this._prefs when calling Prefences.type → FUEL: undefined this._prefs when calling Preferences.type
|
||
Comment 2•16 years ago
|
||
Good catch! Do you have a patch, too? :)
|
Assignee | |
Comment 3•16 years ago
|
||
Assignee: nobody → mark.finkle
Attachment #307383 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #307454 -
Flags: review?(gavin.sharp)
|
|
||
Updated•16 years ago
|
Attachment #307454 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #307454 -
Flags: approval1.9?
|
||
Comment 4•16 years ago
|
||
Comment on attachment 307454 [details] [diff] [review] Fixes Preference.type and adds tests a1.9+=damons
Attachment #307454 -
Flags: approval1.9? → approval1.9+
checked in mozilla/browser/fuel/src/fuelApplication.js new rev 1.26 mozilla/browser/fuel/test/browser_ApplicationPrefs.js new rev 1.3
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Firefox 3 beta5
You need to log in
before you can comment on or make changes to this bug.
Description
•