Closed
Bug 421081
Opened 16 years ago
Closed 16 years ago
Add Modern style and icons for new application pref pane
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file, 1 obsolete file)
5.97 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Bug 417590 only landed classic/default theme styling for the new help app pref pane, we need to add Modern theme support as well.
Assignee | ||
Comment 1•16 years ago
|
||
This patch makes everything align well, eliminates all jumps of icons and labels, and adds the icons (using the same icons as for the default theme right now).
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #307491 -
Flags: superreview?(neil)
Attachment #307491 -
Flags: review?(neil)
Assignee | ||
Comment 2•16 years ago
|
||
Here's a new patch with style rules from Neil and and an order of rules that is IMHO more logical (listitems before menu before menuitems, icons before labels).
Attachment #307491 -
Attachment is obsolete: true
Attachment #307691 -
Flags: superreview?(neil)
Attachment #307691 -
Flags: review?(neil)
Attachment #307491 -
Flags: superreview?(neil)
Attachment #307491 -
Flags: review?(neil)
Comment 3•16 years ago
|
||
Comment on attachment 307691 [details] [diff] [review] add app pane styling for Modern, v2 > skin/modern/communicator/icons/lock-secure.gif (communicator/icons/lock-secure.gif) > skin/modern/communicator/icons/offline.gif (communicator/icons/offline.gif) > skin/modern/communicator/icons/online.gif (communicator/icons/online.gif) > skin/modern/communicator/icons/btn1.gif (communicator/icons/btn1.gif) > skin/modern/communicator/icons/common.png (communicator/icons/common.png) > skin/modern/communicator/icons/common-small.png (communicator/icons/common-small.png) > skin/modern/communicator/icons/search.gif (communicator/icons/search.gif) >+ skin/modern/communicator/icons/alwaysAsk.png (communicator/icons/alwaysAsk.png) >+ skin/modern/communicator/icons/application.png (communicator/icons/application.png) >+ skin/modern/communicator/icons/feedIcon16.png (communicator/icons/feedIcon16.png) >+ skin/modern/communicator/icons/plugin.png (communicator/icons/plugin.png) >+ skin/modern/communicator/icons/save.png (communicator/icons/save.png) Are the existing entries that badly alphabetised? If not, please fix ;-)
Attachment #307691 -
Flags: superreview?(neil)
Attachment #307691 -
Flags: superreview+
Attachment #307691 -
Flags: review?(neil)
Attachment #307691 -
Flags: review+
Assignee | ||
Comment 4•16 years ago
|
||
Checked in with corrections for alphabetical order, thanks.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•