421196 - PopupAutoCompleteRichResult and toolkit style rules use wrong type attribute for rich autocomplete panel

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

browser.xul has:
<panel type="autocomplete-richlistbox" chromedir="&locale.dir;" id="PopupAutoCompleteRichResult" noautofocus="true" hidden="true"/>

but "autocomplete-richlistbox" isn't a valid type for the panel. The real type is "rich-autocomplete", per xul.css. ("autocomplete-richlistbox" appears to be the classname used for the popup's anonymous richlistbox and associated binding.) Turns out this doesn't matter too much, because we override it with an ID selector in browser.css [1], but we should fix it nonetheless to avoid this pattern spreading as people copy/paste our code.

[1] http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.css&rev=1.59&mark=23#22

Some of the toolkit autocomplete rules have selectors that match on that attribute value, as well. We should fix them, otherwise non-Firefox users of that kind of panel will be styled incorrectly.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Neil Deakin]

Comment on attachment 307601 [details] [diff] [review]
patch

xul.css should instead be changed to "autocomplete-richlistbox", as per https://bugzilla.mozilla.org/show_bug.cgi?id=399664#c22

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 4

[Damon Sicore (:damons)]

Comment on attachment 308239 [details] [diff] [review]
patch

a1.9+=damons

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/xul.css 	1.119