421208 - assertion when moving the "Unfiled Bookmarks" folder in Library

Status: RESOLVED WORKSFORME

Description

[juan becerra [:juanb]]

Attachment: assertion dialog when trying to move a bookmarks folder into another

While testing Fx3b4rc1, I selected the Unfiled Bookmarks folder in the Library and then tried to move it into the Bookmarks Menu folder by clicking on the Organize button and using that to move it. I got an "assertion failed" dialog.

STR:
1. Install latest fx3b4 candidate and go to the Bookmarks menu, and select Show All Bookmarks
2. Click on the Unfiled Bookmarks folder in the Library window, and click on the Organize dropdown button.
3. Try to move the folder to the Bookmarks Menu folder and click OK

Expected: You should either be allowed to move the folder inside that other folder, or you should be presented with a nice error message

Actual: Dialog window saying "Assertion Failed" ... See image

Comment 1

[Stephen Donner [:stephend] PTO/paternity - back for All Hands]

Also, this brings up the question: should we be showing end-users JavaScript assertion stacks?  Certainly not for final.

Comment 2

[Dietrich Ayala (:dietrich)]

assertions not shown in final:

http://mxr.mozilla.org/seamonkey/source/toolkit/content/debug.js#73

Comment 3

[Dietrich Ayala (:dietrich)]

In the latest nightly, there's no assertion. However, it also does not move the folder (correct behavior, as it's read only).

I also don't think we should pop up an error message. It be better to not allow read-only items to be selected, or change their icon to indicate their read-only-ness. Hey UX team, any ideas?

Drivers: Regardless of the solution, this is not a blocker. Resetting flag for re-evaluation.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

This is, in fact, WFM.

(In reply to comment #3)
> I also don't think we should pop up an error message. It be better to not allow
> read-only items to be selected, or change their icon to indicate their
> read-only-ness. Hey UX team, any ideas?

A different icon might be nice, but not blocking at this time, filed bug 423895.
We should minimally be using the invalid-drop cursor, filed bug 423897.

Comment 5

[Gervase Markham [:gerv] (not reading bugmail)]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv