Open Bug 421383 Opened 17 years ago Updated 2 years ago

Add bounds checks for ss->xtnData.numAdvertised and ss->xtnData.numNegotiated

Categories

(NSS :: Libraries, defect, P5)

Product:
NSS
Component:
Libraries
Version:
3.12
Type:
defect

Tracking

(Not tracked)

People

(Reporter: wtc, Unassigned)

References

Details

Although our code should never increment ss->xtnData.numAdvertised and ss->xtnData.numNegotiated beyond the ends of the ss->xtnData.advertised and ss->xtnData.negotiated arrays, it would be nice to have explicit array bounds checks before we increment these indexes to put the code reviewers at ease.
We'll add assertions to detect bugs in debug builds. We need to decide what we should do if we detect we'd be going beyond the end of array in optimized builds. Should we ignore the extension or fail the connection?
Assignee: nobody → wtc
Severity: normal → S3

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: wtc → nobody
Severity: S3 → S4
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.