421387 - Startup error in Chinese Sunbird 0.8; timezone guessing is broken

Status: VERIFIED FIXED

(Mozilla Localizations :: zh-CN / Chinese (Simplified), defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.13pre) Gecko/20080305 Sunbird/0.8

Starting Sunbird 0.8 or Lightning 0.8 shows error during the timezone guessing:

??: ?????? '??/??'. TypeError: tz has no properties
???:chrome://calendar/content/calUtils.js
?:660

The error happens because the string "likelyTimezone" has been translated:
http://mxr.mozilla.org/l10n-mozilla1.8/source/zh-CN/calendar/chrome/calendar/calendar.properties#240

but must be in English:

http://mxr.mozilla.org/mozilla1.8/source/calendar/locales/en-US/chrome/calendar/calendar.properties#214
# LOCALIZATION NOTE (likelyTimezone):
#   Translators, please put the most likely timezone(s) where the people using
#   your locale will be.  Use the Olson ZoneInfo timezone name *in English*,

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I'm taking this, patch coming up shortly.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v1

This patch replaces the string that should not have been translated, with the corresponding English counterpart.

Comment 3

[Shaohua Wen]

Comment on attachment 307859 [details] [diff] [review]
patch v1

Thanks!

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v2

Actually, Shanghai would be a better choice since zh-CN users are likely to be in China than in New York.

Please check this patch in instead. Thanks!

Comment 5

[Shaohua Wen]

Yes , you are right! :P

Comment 6

[Stefan Sitter [:ssitter]]

Please note that we already switched the tinderbox to release preparation mode. This means you will have to submit your changes to SUNBIRD_0_8_BRANCH as well to take effect. http://groups.google.com/group/mozilla.dev.l10n/msg/1d11a4a12be3062d

Comment 7

[Stefan Sitter [:ssitter]]

Issue still exists using Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.13pre) Gecko/2008030920 Sunbird/0.8.

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #5)
> Yes , you are right! :P

Shaohua, please check in patch v2. Thanks!

Comment 9

[Shaohua Wen]

patch V2 checked in.

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #9)
> patch V2 checked in.
> 

Fixed on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; zh-CN; rv:1.8.1.13pre) Gecko/20080311 Sunbird/0.8

Comment 11

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; zh-CN; rv:1.8.1.13pre) Gecko/20080317 Sunbird/0.8