Closed Bug 421387 Opened 12 years ago Closed 12 years ago

Startup error in Chinese Sunbird 0.8; timezone guessing is broken

Categories

(Mozilla Localizations :: zh-CN / Chinese (Simplified), defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: gkw)

References

Details

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.13pre) Gecko/20080305 Sunbird/0.8

Starting Sunbird 0.8 or Lightning 0.8 shows error during the timezone guessing:

??: ?????? '??/??'. TypeError: tz has no properties
???:chrome://calendar/content/calUtils.js
?:660

The error happens because the string "likelyTimezone" has been translated:
http://mxr.mozilla.org/l10n-mozilla1.8/source/zh-CN/calendar/chrome/calendar/calendar.properties#240

but must be in English:

http://mxr.mozilla.org/mozilla1.8/source/calendar/locales/en-US/chrome/calendar/calendar.properties#214
# LOCALIZATION NOTE (likelyTimezone):
#   Translators, please put the most likely timezone(s) where the people using
#   your locale will be.  Use the Olson ZoneInfo timezone name *in English*,
I'm taking this, patch coming up shortly.
Status: NEW → ASSIGNED
Assignee: shaohua.wen → nth10sd
Status: ASSIGNED → NEW
Attached patch patch v1 (obsolete) — Splinter Review
This patch replaces the string that should not have been translated, with the corresponding English counterpart.
Attachment #307859 - Flags: review?(shaohua.wen)
Comment on attachment 307859 [details] [diff] [review]
patch v1

Thanks!
Attachment #307859 - Flags: review?(shaohua.wen) → review+
Attached patch patch v2Splinter Review
Actually, Shanghai would be a better choice since zh-CN users are likely to be in China than in New York.

Please check this patch in instead. Thanks!
Attachment #307859 - Attachment is obsolete: true
Yes , you are right! :P
Please note that we already switched the tinderbox to release preparation mode. This means you will have to submit your changes to SUNBIRD_0_8_BRANCH as well to take effect. http://groups.google.com/group/mozilla.dev.l10n/msg/1d11a4a12be3062d
Issue still exists using Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.13pre) Gecko/2008030920 Sunbird/0.8.
(In reply to comment #5)
> Yes , you are right! :P

Shaohua, please check in patch v2. Thanks!
patch V2 checked in.
(In reply to comment #9)
> patch V2 checked in.
> 

Fixed on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; zh-CN; rv:1.8.1.13pre) Gecko/20080311 Sunbird/0.8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; zh-CN; rv:1.8.1.13pre) Gecko/20080317 Sunbird/0.8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.