Closed Bug 421464 Opened 12 years ago Closed 12 years ago

Make "type" attribute on <style> element optional

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: jwatt)

References

()

Details

Attachments

(1 file)

The SVG WG has decided the "type" attribute on the <style> element should be optional, to match HTML's <style> element. We should fix that, it should be easy.
Flags: blocking1.9?
Attached patch patchSplinter Review
It is easy, and yes, we should do this.
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #307901 - Flags: superreview?(roc)
Attachment #307901 - Flags: review?(longsonr)
Comment on attachment 307901 [details] [diff] [review]
patch

>+  if (aType.IsEmpty()) {
>+    aType += NS_LITERAL_STRING("text/css").get();

Isn't assignLiteral better/simpler?

aType.AssignLiteral("text/css")

r=longsonr with that, assuming that works.

>+  }
> 
>   return;
> }
Attachment #307901 - Flags: review?(longsonr) → review+
Comment on attachment 307901 [details] [diff] [review]
patch

what Robert said
Attachment #307901 - Flags: superreview?(roc) → superreview+
Yup.
Flags: blocking1.9? → blocking1.9+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.