421484 - Tinderbox can't test for existing symlink on stage-new

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

A while back, we introduced this code to tinderbox
 push(@cmds,"ssh $ssh_opts -l $Settings::ssh_user $ssh_server 'cd $remote_path && if [ ! -h $short_ud ]; then ln -s ${datedir}${short_ud} .; fi'");
which makes a symlink from
   firefox/nightly/2008-03-06-09-mozilla1.8
to where the files really are in
   firefox/nightly/2008/03/2008-03-06-09-mozilla1.8

The chroot jail used on stage-new doesn't have a real shell, so the test fails and we don't get a symlink. This is the last step so the builds still get published, they're just kinda hidden away.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Force symlink creation without testing for existence

I'm testing this on some low-priority builds.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Force symlink creation without testing for existence v2

Not allowed to use && apparently, so make an absolute link rather than a relative one.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Relative symlink without needing a cd

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 308392 [details] [diff] [review]
Relative symlink without needing a cd

This should work fine on the existing stage, and on the new system. It'll just fail if there is already a link or directory with the same name, which avoids dataloss in the latter case.

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 308392 [details] [diff] [review]
Relative symlink without needing a cd

I like the curly braces when concatenating multiple vars into a single path, but that's just me.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: patch as checked in

Checking in post-mozilla-rel.pl;
/cvsroot/mozilla/tools/tinderbox/post-mozilla-rel.pl,v  <--  post-mozilla-rel.pl
new revision: 1.144; previous revision: 1.143
done

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I'll keep an eye on the nightlies tomorrow for any fallout.