421528 - 3.0b4rc1 win32 builds didn't use PGO

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Bad news for PGO on win32 for b4 - the rc1 build didn't perform PGO because of a tinderbox setup problem. Basically the copy of build-seamonkey-util.pm in /e/fx19rel/ was stale compared to the CVS checkout. :-(

The gory details - from the build log side:
* The build log is at      (requires MPT VPN)
   http://production-trunk-automation.build.mozilla.org:8810/win32_build/builds/7/step-shell_7/0

* It should contain lines like these from the nightly    (paths are different)
   make -f /e/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/client.mk build MOZ_PROFILE_GENERATE=1
   ...
   OBJDIR=obj-fx-trunk python obj-fx-trunk/_profile/pgo/profileserver.py
   ...
   make -f /e/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/client.mk build MOZ_PROFILE_USE=1
 but doesn't

From poking around on  fx-win32-1.9-slave2:
* PGO requires at least rev 1.383 of that tinderbox/build-seamonkey-util.pm. This was added in bug 418502
* The master CVS checkout for tinderbox is /e/builds/tinderbox/mozilla/tools/tinderbox, which is on the RELEASE_AUTOMATION_M7_2 tag (correct), giving rev 1.385 of build-seamonkey-util.pm
* MSYS doesn't support symlinks, so the tinderbox code in the build dir (/e/fx19rel) is a copy of the checkout. Looks like these weren't updated, as it matches rev1.376 from CVS.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Nick, are you really talking about beta4 and not beta5? 

Comment 2

[(not currently active) Ted Mielczarek]

Yes, this was a problem with beta 4 RC1.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Rob fixed this.