421635 - [EM] post restart notification should specify foreground color

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Takeshi Kurosawa :takenspc]

Attachment: Patch v1 (winstripe and gnomestripe)

Bug 408115 introduced post-restart notifications.
But |richlistitem[newAddon="true"]| doesn't have foreground color rule. They are hard to read on some OS themes.

Let's specify foreground color.

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Screenshot

Screenshot showing the problem.

Comment 2

[Takeshi Kurosawa :takenspc]

Attachment: Screenshot with patch

Screenshot with patch.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 308091 [details] [diff] [review]
Patch v1 (winstripe and gnomestripe)

Thanks for catching this. Could you also do the same for pinstripe?

Comment 4

[Takeshi Kurosawa :takenspc]

Attachment: Patch v2

Added pinstripe (|color| comes from |notification[type="warning"]|)
http://mxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/notification.css#14

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 308101 [details] [diff] [review]
Patch v2

r=me - thank you much for this

Comment 6

[Robert Strong (they/them - no direct email)]

ccing Mossop so he knows about this change

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 308101 [details] [diff] [review]
Patch v2

a1.9+=damons

Comment 8

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.16; previous revision: 1.15
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.40; previous revision: 1.39
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.49; previous revision: 1.48
done