Closed Bug 421635 Opened 14 years ago Closed 14 years ago

[EM] post restart notification should specify foreground color

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta5

People

(Reporter: takenspc, Assigned: takenspc)

References

Details

Attachments

(3 files, 1 obsolete file)

Bug 408115 introduced post-restart notifications.
But |richlistitem[newAddon="true"]| doesn't have foreground color rule. They are hard to read on some OS themes.

Let's specify foreground color.
Attachment #308091 - Flags: review?(robert.bugzilla)
Attached image Screenshot
Screenshot showing the problem.
Attached image Screenshot with patch
Screenshot with patch.
Comment on attachment 308091 [details] [diff] [review]
Patch v1 (winstripe and gnomestripe)

Thanks for catching this. Could you also do the same for pinstripe?
Attached patch Patch v2Splinter Review
Added pinstripe (|color| comes from |notification[type="warning"]|)
http://mxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/notification.css#14
Attachment #308091 - Attachment is obsolete: true
Attachment #308101 - Flags: review?(robert.bugzilla)
Attachment #308091 - Flags: review?(robert.bugzilla)
Comment on attachment 308101 [details] [diff] [review]
Patch v2

r=me - thank you much for this
Attachment #308101 - Flags: review?(robert.bugzilla) → review+
ccing Mossop so he knows about this change
Comment on attachment 308101 [details] [diff] [review]
Patch v2

a1.9+=damons
Attachment #308101 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
OS: Linux → All
Hardware: PC → All
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.16; previous revision: 1.15
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.40; previous revision: 1.39
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.49; previous revision: 1.48
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
You need to log in before you can comment on or make changes to this bug.