Closed
Bug 421695
Opened 17 years ago
Closed 17 years ago
Toolbar and MenuBar shadows should not be saved
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: ispence, Assigned: ispence)
Details
Attachments
(1 file)
|
5.35 KB,
patch
|
roc
:
review+
roc
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
For some reason, in gtkdrawing.c we save the shadow-type property of both our toolbar widget and our menubar widget. This leads to issues when someone changes a theme, since we now have the wrong shadow-type saved.
I'm going to attach a patch that has us treat shadow-type for those two widgets the same way we treat it for all of our other widgets.
|
Assignee | |
Comment 1•17 years ago
|
||
This removes 3 global variables and a version check that is no longer necessary.
Assignee: nobody → ispence
Status: NEW → ASSIGNED
Attachment #308158 -
Flags: superreview?(roc)
Attachment #308158 -
Flags: review?(roc)
Attachment #308158 -
Flags: superreview?(roc)
Attachment #308158 -
Flags: superreview+
Attachment #308158 -
Flags: review?(roc)
Attachment #308158 -
Flags: review+
|
||
Updated•17 years ago
|
Attachment #308158 -
Flags: approval1.9?
|
||
Comment 2•17 years ago
|
||
Comment on attachment 308158 [details] [diff] [review]
Fix various uses of shadow-type
a1.9+=damons
Attachment #308158 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•17 years ago
|
||
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v <-- gtk2drawing.c
new revision: 1.91; previous revision: 1.90
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
You need to log in
before you can comment on or make changes to this bug.
Description
•