421716 - CalDAV provider should support getctag

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, enhancement)

Description

[Bruno Browning]

Apple's getctag extension to CalDAV allows for better performance and lighter network use when we need to refresh() and nothing on the remote calendar has changed. We should detect when the server supports it and use it if so.

Comment 1

[Bruno Browning]

Attachment: add getctag

tested against Apple (supports getctag) and DAViCal (no getctag support yet).

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 331734 [details] [diff] [review]
add getctag

What happens if the server doesn't support ctags? Maybe we should save a bit so that we don't check every time when we know the server doesn't support them.

I'd prefer something like CS as the calendarserver.org namespace variable, but its up to you.

r=philipp

r=philipp

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: add getctag - v2

I did find some additional problems, attaching my review comments in form of a new patch.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Also one thing I've noticed is that if you add an item and then reload, then items are always fetched. I guess it would be too much to:

1. get ctag before add/modify/delete. If it matches the cached ctag, save it
   for step 3.
2. do add/modify/delete
3. If saved ctag in step 1, get the ctag again and cache it locally

Or is there a way the ctag can be retrieved together with adding the item?

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED