Closed
Bug 421767
Opened 16 years ago
Closed 16 years ago
element.attributes.removeNamedItemNS(<non-existent attribute NS and name>) returns null instead of throwing
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
Attachments
(1 file)
|
2.61 KB,
patch
|
jst
:
review+
jst
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Trivial fix, a point on acid3 -- and already covered in our existing tests via todos expecting them to fail! Win all around, easiest acid3 point evar.
Attachment #308256 -
Flags: superreview?(jst)
Attachment #308256 -
Flags: review?(jst)
I applied the patch, though I didn't see any points gained from the test.
|
Assignee | |
Comment 2•16 years ago
|
||
Test 67 passes with this patch and fails without it in my tree. Double-check you're not hitting non-determinism in the results of other tests.
ah yes, further testing confirmed it. The patch fixes test 67. Just having issues with the test numbers varying for some reason.
|
||
Updated•16 years ago
|
Attachment #308256 -
Flags: superreview?(jst)
Attachment #308256 -
Flags: superreview+
Attachment #308256 -
Flags: review?(jst)
Attachment #308256 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #308256 -
Flags: approval1.9?
|
||
Comment 4•16 years ago
|
||
Comment on attachment 308256 [details] [diff] [review] Patch, remove some todos a1.9=beltzner
Attachment #308256 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Fixt.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•