421897 - Need a way to set the title immediately (SetPageTitle uses LAZY_ADD)

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

follow-up to bug 419749

We have no way to change a page title immediately,
because SetPageTitle uses a LAZY_ADD, while a third party user (and on our unit tests) we could check the title before it is actually changed. 

The only way to set the title immediately is using AddPageWithDetails,
but still that requires that we also need to add a visit (transition_link).
We could modify AddPageWithDetails so that it adds a visit only if
(aLastVisited), and maybe add a 4th param as transition argument since we could
want to add a first visit that is not a transition_link.

As a third party user, i could expect that setPageTitle is an immediate
change, since in the nsIGlobalHistory2 interface definition there's no comment
about lazy mode
(http://lxr.mozilla.org/seamonkey/source/docshell/base/nsIGlobalHistory2.idl#91)

Comment 1

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 2

[Marco Bonardo [:mak]]

lazy_add died so this doesn't apply anymore, currently SetPageTitle is sync, even if probably now we want it to be async :)