42213 - Mac-Security prefs not saved to disk

Status: VERIFIED WORKSFORME

(Core Graveyard :: Security: UI, defect, P3)

Description

[John Unruh]

M16 Commercial builds - Win32 and Linux.
1.) Open PSM by clicking on the lock.
2.) Click on Applications, and deselect all four options.
3.) Close PSM and restart Netscape.
4.) Open PSM and click on Applications.
What is expected: That the prefs would be deselected.

Comment 1

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

FYI - Build 2000-06-12-01-M16/
jar crashed and had to reboot (WinNT)
leger froze the app and had to force quit (Win95)
doing these four steps to reproduce this bug.

Adding crash keyword.

Comment 2

[John Unruh]

*** Bug 43145 has been marked as a duplicate of this bug. ***

Comment 3

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 4

[John Unruh]

*** Bug 40496 has been marked as a duplicate of this bug. ***

Comment 5

[Javier Delgadillo]

This appears to be a bug in the prefs library which does not mark any of the 
security preferences as having user values and always returns the default value 
even when the user changes the value.

Who in prefs land can take a look at this to tell me how to fix this?  Or fix 
the prefs library to have the expected behavior.

Comment 6

[Javier Delgadillo]

Adding mstoltz to cc list since he knows something about security prefs.

Comment 7

[Mitchell Stoltz (not reading bugmail)]

I'm looking at it, but I can't figure out what's going wrong. I don't think the 
fact that it's a security pref is the issue here, since the security check is 
succeeding (as it should). After the security check, we call PREF_SetBoolPref as 
always, which should set the USER_SET or whatever flag to true. cc'ing alec.

Comment 8

[Javier Delgadillo]

Here's another data point for alecf and mstoltz to help me out with.

When we call mPrefs->SetBoolPref() the flags do get update to include
PREF_USER_VALUE, but when we call mPrefs->GetBoolPref the next time around, the
flags have been re-set to only include 0x80

Any clues as to where the flags may be getting cleared?

Comment 9

[Javier Delgadillo]

Turns out that Mozilla didn't like the JavaScript that was used to save the
prefs in the security advisor.  I re-wrote the bit of JS Mozilla didn't like and
now the preferences are saved to disk.  You need a version of PSM build on or
after 7/18 to see this work.

Comment 10

[John Unruh]

Reopening. Some prefs still are not saved.
1.) Open PSM, and click on Applications and Navigator.
2.) Select "Ask every time."
3.) Click on advanced and options.
4.) Deselect one or both SSL versions.
5.) Close PSM, close Netscape 6, and restart.
What happens: Open PSM and view the same prefs. They are not saved. WinNT build 
71720, PSM.exe build 7/18 3:10 AM.
What happens: Those prefs are not saved.

Comment 11

[Javier Delgadillo]

Fixed all other prefs except S/MIME prefs.  Since Mozilla doesn't do S/MIME it
doesn't support those prefs anyway.  You'll need a build from 7/19 or later of
PSM. 

Comment 12

[Doug Turner (:dougt)]

javi - this did at some point work.  what javascript stop working?  what did you 
have to change?

Comment 13

[Javier Delgadillo]

I don't know if this ever worked.  It involved re-writing some inputs that 
looked like this:

<input type=...  onClick="top.variableName = value;">

to 

<input type=.. onClick="top.setVariableValue();">

Once the appropriate setVariableValue was defined, everything worked just fine.

Comment 14

[John Unruh]

Reopening. Verified on WinNT and Linux - still a problem with Mac. Removing 
crash keyword.

Comment 15

[John Unruh]

Fixed

Comment 16

[John Unruh]

Verified.

Comment 17

[John Unruh]

Reopening. I fixed and verified the wrong bug.

Comment 18

[leger]

javi, can we get and ETA on a fix please.  Need fixed ASAP to make beta2.

Comment 19

[Javier Delgadillo]

I don't have an ETA for this.  Sorry to say I don't have a Mac that builds just 
yet (I'm gonna start working on that.)

When I fixed this problem for the other platforms, there was a bug in JavaScript 
that I had to code around in the JavaScript for the security advisor.  Look at 
my previous comment in this bug for how I worked around the problem.  The actual 
problem I believe lies in JavaScript.

Comment 20

[David P. Drinan]

I think the problem is that the MAC psm from a branch tag (SECURITY_MAC_BRANCH) 
which has not been updated with your fix. The question is do we update the 
branch tag or move the branch tag to the tip of PSM.

Comment 21

[leger]

Per today's PR2 open nsbeta2+ bug triage, we are moving this bug from [nsbeta2+] 
 to [nsbeta2-].  Adding relnote2 keyword.  junruh, please get text to verah.

Comment 22

[John Unruh]

Relnote sent to vera - "Mac-Security prefs not saved to disk" Changes to 
preferences in the Mac Security Advisor are not saved to disk.

Comment 23

[Javier Delgadillo]

Will work on updating the Mac codebase to other platforms this week.  Hopefully 
the PSM_MAC_BRANCH will be updated by the end of this week.

Comment 24

[John Unruh]

Worksforme now.

Comment 25

[John Unruh]

Verified with build 081804.

Comment 26

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 27

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 28

[Michael Lefevre]

fixing null OS field on old bugs