Closed
Bug 422161
Opened 16 years ago
Closed 16 years ago
Fix JS strict error in *.jsm
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 beta5
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(1 file, 1 obsolete file)
10.63 KB,
patch
|
mattwillis
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
With strict error checking enabled, JSON.jsm has the following error: undefined variable: EXPORTED SYMBOLS
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #308660 -
Flags: review?(gavin.sharp)
Attachment #308660 -
Flags: approval1.9?
Comment 2•16 years ago
|
||
Comment on attachment 308660 [details] [diff] [review] rev0 - declare it Hmm, a lot of modules have this bug. Can you fix them as well? rs=me.
Attachment #308660 -
Flags: review?(gavin.sharp) → review+
Comment 3•16 years ago
|
||
Comment on attachment 308660 [details] [diff] [review] rev0 - declare it Please re-request approval once reviews are completed.
Attachment #308660 -
Flags: approval1.9?
Assignee | ||
Updated•16 years ago
|
Attachment #308660 -
Flags: approval1.9?
Assignee | ||
Comment 4•16 years ago
|
||
Um... Gavin gave r+ about 6 minutes before you posted that. I'm guessing you crossed in the mail. Rerequesting a1.9?
Assignee | ||
Updated•16 years ago
|
Summary: Fix JS strict error in JSON.jsm → Fix JS strict error in *.jsm
Assignee | ||
Comment 5•16 years ago
|
||
Carrying forward gavin's r and implied rs.
Attachment #308660 -
Attachment is obsolete: true
Attachment #308883 -
Flags: review+
Attachment #308883 -
Flags: approval1.9?
Attachment #308660 -
Flags: approval1.9?
Comment 6•16 years ago
|
||
Comment on attachment 308883 [details] [diff] [review] rev1 - Fixes _all_ the .jsm files with this error as gavin requested. a1.9+=damons
Attachment #308883 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 7•16 years ago
|
||
Landed on trunk. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•