422209 - Twinkle (TW) is not working in Firefox 3 beta 4

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P2)

Description

[Carlos Roberto]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4

Rollback, vandalism warnings, speedy deletion (CSD) and other functions are not working in Firefox 3 beta 4. However they work fine in beta 3.

Twinkle is a set of JavaScripts that gives registered users several new options to assist them in common Wikipedia maintenance tasks and to help them deal with acts of vandalism:
http://en.wikipedia.org/wiki/Wikipedia:WikiProject_User_scripts/Scripts/Twinkle

You can see the source code here:
http://en.wikipedia.org/wiki/User:AzaToth/twinkle.js

Reproducible: Always

Steps to Reproduce:
1. Install Twinkle in a account with at least 4 days.
2. Go to http://en.wikipedia.org/wiki/Wikipedia:Sandbox and try to revert a edit with TW. It fails.
3. Go to http://en.wikipedia.org/wiki/Wikipedia:Sandbox and try to tag page for speedy deletion using CSD button at top right of screen. It fails.
Actual Results:  
Twinkle's functions are not working on Wikipedia.

Expected Results:  
TW should works fine in 3b4 like 3b3.

Comment 1

[Mike Shaver (:shaver emeritus)]

Anything in the Error Console?

Comment 2

[Carlos Roberto]

Additional information:
To revert an edit you must go to page history a get a diff of edit. For example, in this page: http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=197552676&oldid=197551485 you will see button [restore this version] if you click, TW will attempt to revert to this version, but fails in 3b4.

@Mike Shaver

According to User:Gary King: http://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_User_scripts/Scripts/Twinkle#Twinkle_stopped_working.3F

The JavaScript error message on Mac OS X with Firefox 3b4 is:

Error: undefined entity
Source File: http://en.wikipedia.org/w/index.php?title=Wikipedia%3ASandbox&action=submit
Line: 159, Column: 99
Source Code:
<input name="wpMinoredit" type="checkbox" value="1" tabindex="3" accesskey="i" id="wpMinoredit" />&nbsp;
<label for='wpMinoredit' title="Mark this as a minor edit [i]" accesskey="i">This is a minor edit
<span id="minoredit_helplink" style="font-size: small;"> (<a href="/wiki/Help:Minor_edit" title="Help:Minor edit">what's this?</a>)</span></label>

Comment 3

[Carlos Roberto]

When trying to revert some one edit I get this:

Error: undefined entity
Source File: http://en.wikipedia.org/w/index.php?title=Wikipedia%3ASandbox&action=submit
Line: 165, Column: 117
Source Code:
<input name="wpMinoredit" type="checkbox" value="1" checked="checked" tabindex="3" accesskey="i" id="wpMinoredit" />&nbsp;<label for='wpMinoredit' title="Mark this as a minor edit [i]" accesskey="i">This is a minor edit<span id="minoredit_helplink" style="font-size: small;"> (<a href="/wiki/Help:Minor_edit" title="Help:Minor edit">what's this?</a>)</span></label>

Warning: Error in parsing value for property 'background'.  Declaration dropped.
Source File: http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=197558133&oldid=197557485
Line: 0

Warning: Error in parsing value for property 'width'.  Declaration dropped.
Source File: http://en.wikipedia.org/w/index.php?title=Wikipedia:Sandbox&diff=197558133&oldid=197557485
Line: 0

Comment 4

[Bob Clary [:bc] (inactive)]

sounds more like xml parsing than JavaScript Engine to me.

Comment 5

[Carlos Roberto]

Trying to delete an image I get this:

Error: undefined entity
Source File: http://en.wikipedia.org/w/index.php?title=Image%3AYucca%20elata%20fh%201181.11%2C%20White%20Sands%2C%20New%20Mexico%20BB.jpg&action=delete
Line: 202, Column: 146
Source Code:
    <input type='submit' name="go" class="searchButton" id="searchGoButton" value="Go" title="Go to a page with this exact name if one exists" />&nbsp;

Error: form is undefined
Source File: http://en.wikipedia.org/w/index.php?title=User%3AAzaToth%2Ftwinklespeedy.js&action=raw&ctype=text/javascript
Line: 860

Comment 7

[Carlos Roberto]

Guys this bug seems to be partially fixed in the nightly/latest-trunk.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031205 Minefield/3.0b5pre

Rollback, vandalism warnings and CSD are working properly.

When tagging an image for "di" TW fails to warn the author of image about the "di" tag:

Error: form is null
Source File: http://en.wikipedia.org/w/index.php?title=User%3AAzaToth%2Ftwinkleimage.js&action=raw&ctype=text/javascript
Line: 225

Comment 8

[Robert Sayre]

blocking for now, is this still on issue on the latest nightly?

Comment 9

[Carlos Roberto]

Rollback, vandalism warnings are working properly.
CSD, "di", PROD tags and warnings are working properly.
RFPP are also working.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031905 Minefield/3.0b5pre

I just not tested articles for deletion (AfD) and other pages (XfD).

The issue with "di" warning is also fixed. So, I think this bug can be closed.