"Edit Attribute" > "Namespace URI" is not selected onload

RESOLVED FIXED

Status

Other Applications
DOM Inspector
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Takeshi Kurosawa, Assigned: Takeshi Kurosawa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.60 KB, patch
db48x
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 308812 [details] [diff] [review]
Patch

When editing an attribute which has no namespace, "Namespace URI" menulist of "Edit Attribute" dialog is not selected (selecteIndex == -1) onload.
Attachment #308812 - Flags: review?(db48x)
(Assignee)

Comment 1

10 years ago
Comment on attachment 308812 [details] [diff] [review]
Patch

>-    var menuitems  = this.menulist.firstChild.childNodes;

This variable is not used. So I remove it. Should I file this change as another bug?
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
It's fine to remove it here.

Would you be willing to add a test for this change?  I'm trying to start to land tests with bug fixes so we don't regress things in the future.

Updated

10 years ago
Blocks: 420105
Comment on attachment 308812 [details] [diff] [review]
Patch

r=db48x
Attachment #308812 - Flags: review?(db48x) → review+

Updated

10 years ago
Attachment #308812 - Flags: superreview?(neil)

Updated

10 years ago
Attachment #308812 - Flags: superreview?(neil) → superreview+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Assignee: nobody → taken.spc
Status: ASSIGNED → NEW
Checking in extensions/inspector/resources/content/viewers/domNode/domNodeDialog.js;
/cvsroot/mozilla/extensions/inspector/resources/content/viewers/domNode/domNodeDialog.js,v  <--  domNodeDialog.js
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.