Closed
Bug 422336
Opened 16 years ago
Closed 16 years ago
"Edit Attribute" > "Namespace URI" is not selected onload
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: takenspc, Assigned: takenspc)
References
Details
Attachments
(1 file)
1.60 KB,
patch
|
db48x
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
When editing an attribute which has no namespace, "Namespace URI" menulist of "Edit Attribute" dialog is not selected (selecteIndex == -1) onload.
Attachment #308812 -
Flags: review?(db48x)
Assignee | ||
Comment 1•16 years ago
|
||
Comment on attachment 308812 [details] [diff] [review] Patch >- var menuitems = this.menulist.firstChild.childNodes; This variable is not used. So I remove it. Should I file this change as another bug?
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Comment 2•16 years ago
|
||
It's fine to remove it here. Would you be willing to add a test for this change? I'm trying to start to land tests with bug fixes so we don't regress things in the future.
Comment 3•16 years ago
|
||
Comment on attachment 308812 [details] [diff] [review] Patch r=db48x
Attachment #308812 -
Flags: review?(db48x) → review+
Updated•16 years ago
|
Attachment #308812 -
Flags: superreview?(neil)
Updated•16 years ago
|
Attachment #308812 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Updated•16 years ago
|
Assignee: nobody → taken.spc
Status: ASSIGNED → NEW
Comment 4•16 years ago
|
||
Checking in extensions/inspector/resources/content/viewers/domNode/domNodeDialog.js; /cvsroot/mozilla/extensions/inspector/resources/content/viewers/domNode/domNodeDialog.js,v <-- domNodeDialog.js new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•