422476 - make last checkbox in colors dialogue multiline to avoid content clipping in localized builds

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Pascal Chevrel:pascalc]

Attachment: screenshot showing the problem

After doing QA on all locales for beta4, I noticed that 2/3 of our locales have width issues with some of the dialogues, particularly the Colors dialogue.

The reason is that the content of the box is positionned regarding to the width of the last check box and most of our locales have a longer string than en-US.

For locales that change the width of the window, it can lead to a very wide and almost empty dialogue so as to avoid clipping.

See screenshot to see the problem

Comment 1

[Pascal Chevrel:pascalc]

Attachment: patch to minimize the problem

here is a patch to fix the problem I described (this is my first patch, I hope I did it correctly)

Comment 2

[Pascal Chevrel:pascalc]

Attachment: screenshot post patch

this is a screenshot of the result after the patch is applied.

Comment 3

[Pascal Chevrel:pascalc]

After talking about it in l10-drivers meeting, changing priority

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: slightly modified patch

The explicit height in that patch is a bit hacky - this seems to work just as well, though I admit to being confused about why these xul.css style rules are there. The prefwindow/prefpane bindings seem to have all sorts of ugly explicit resizing code (to make animateFadeIn behavior work, I guess?).

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315557 [details] [diff] [review]
slightly modified patch

a1.9=beltzner

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Checked in:
mozilla/browser/components/preferences/colors.xul 	1.9
mozilla/toolkit/content/xul.css 	1.121