Closed
Bug 422620
Opened 17 years ago
Closed 17 years ago
Remove NS_BrightenColor and NS_DarkenColor
Categories
(Core Graveyard :: GFX, defect)
Core Graveyard
GFX
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.9beta5
People
(Reporter: alfredkayser, Assigned: alfredkayser)
Details
(Keywords: memory-footprint)
Attachments
(1 file, 1 obsolete file)
6.43 KB,
patch
|
vlad
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
Remove NS_BrightenColor and NS_DarkenColor, as they are defined in nsColor, but nowhere used. Also they use a fixed hardcode factor to the adjustment, making them not useful generic functions to keep around.
Attachment #309072 -
Flags: review?(vladimir)
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → alfredkayser
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•17 years ago
|
||
Also NS_ASCIIHexToRGB and NS_RGBToASCIIHex are not used anywhere (anymore?)
(see http://lxr.mozilla.org/mozilla/ident?i=NS_ASCIIHexToRGB)
(see http://lxr.mozilla.org/mozilla/ident?i=NS_RGBToASCIIHex)
With this patch, the .obj size is 10K less.
Attachment #309072 -
Attachment is obsolete: true
Attachment #309077 -
Flags: review?
Attachment #309072 -
Flags: review?(vladimir)
Assignee | ||
Updated•17 years ago
|
Attachment #309077 -
Flags: review? → review?(vladimir)
Attachment #309077 -
Flags: review?(vladimir) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #309077 -
Flags: approval1.9?
Updated•17 years ago
|
Component: Layout: Misc Code → GFX
QA Contact: layout.misc-code → general
Version: unspecified → Trunk
Comment 2•17 years ago
|
||
Comment on attachment 309077 [details] [diff] [review]
V2: Also remove the ASCIIHex functions
a1.9+=damons
Attachment #309077 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 3•17 years ago
|
||
Checking in gfx/public/nsColor.h;
/cvsroot/mozilla/gfx/public/nsColor.h,v <-- nsColor.h
new revision: 1.26; previous revision: 1.25
done
Checking in gfx/src/nsColor.cpp;
/cvsroot/mozilla/gfx/src/nsColor.cpp,v <-- nsColor.cpp
new revision: 3.36; previous revision: 3.35
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
Assignee | ||
Comment 4•17 years ago
|
||
Verified:
libgkgfx.so
Total: -608 (+9/-617)
Code: -617 (+0/+0)
Data: +9 (+9/-617)
-608 (+9/-617) text (DATA)
-608 (+9/-617) UNDEF:libgkgfx.so:text
+9 .nosyms.text
-19 nsAutoString::~nsAutoString()
-19 NS_ConvertASCIItoUTF16::~NS_ConvertASCIItoUTF16()
-28 nsAutoString::nsAutoString()
-43 nsACString_internal::BeginWriting()
-49 NS_ConvertASCIItoUTF16::NS_ConvertASCIItoUTF16(nsACString_internal const&)
-69 NS_ASCIIHexToRGB(nsCString const&, unsigned int*)
-88 NS_RGBToASCIIHex(unsigned int, nsCString&)
-140 NS_DarkenColor(unsigned int)
-162 NS_BrightenColor(unsigned int)
Assignee | ||
Updated•17 years ago
|
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•