422637 - Merge nsColorNames into nsColor to have fewer public functions and less code

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Alfred Kayser]

Attachment: V1: Merge nsColorNames into nsColor

merge nsColor and nsColorName
    nsColor is only user of nsLookupName of nsColorName
    GetStringValue is nowhere used.
    kColors public member of nsColorName is only used in nsColor (and TestColorNames...)

The only real function of nsColorName is used by NS_ColorNameToRGB from nsColor, so instead of exposing nsColorName as a separate class, embed it into nsColor. 

This results in less code, saving about 2K from gkgfx.lib (and about 22K objectsize).

Comment 1

[Alfred Kayser]

Attachment: V2: Updated to current trunk

Comment 2

[Alfred Kayser]

Comment on attachment 337057 [details] [diff] [review]
V2: Updated to current trunk

Changed the patch so that no change to layout/build is needed anymore, but still with all the code removal in place.

Less=More!

Comment 3

[Alfred Kayser]

Requesting 'Wanted1.9.1' for a simple and reviewed code saving patch.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Please don't abuse the blocking/wanted process to get people to do reviews.

Comment 5

[Alfred Kayser]

That was not the intention. I thought the wanted flag is needed for checkin into FF3.1?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> That was not the intention. I thought the wanted flag is needed for checkin
> into FF3.1?

It isn't (at least not yet).

Comment 7

[Reed Loden [:reed]]

http://hg.mozilla.org/mozilla-central/rev/003a5a6570af

Comment 8

[Reed Loden [:reed]]

This caused bustage, but it was easy to fix.

http://hg.mozilla.org/mozilla-central/rev/580e62ad39ae

Comment 9

[Aakash Desai [:aakashd]]

Seeing as there hasn't been any discussions about this bug for 5 months and it's not really a testable bug, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.