Closed Bug 422637 Opened 15 years ago Closed 14 years ago
Color Names into ns Color to have fewer public functions and less code
merge nsColor and nsColorName nsColor is only user of nsLookupName of nsColorName GetStringValue is nowhere used. kColors public member of nsColorName is only used in nsColor (and TestColorNames...) The only real function of nsColorName is used by NS_ColorNameToRGB from nsColor, so instead of exposing nsColorName as a separate class, embed it into nsColor. This results in less code, saving about 2K from gkgfx.lib (and about 22K objectsize).
Comment on attachment 337057 [details] [diff] [review] V2: Updated to current trunk Changed the patch so that no change to layout/build is needed anymore, but still with all the code removal in place. Less=More!
Attachment #337057 - Flags: review?(vladimir) → review+
Requesting 'Wanted1.9.1' for a simple and reviewed code saving patch.
Please don't abuse the blocking/wanted process to get people to do reviews.
That was not the intention. I thought the wanted flag is needed for checkin into FF3.1?
Attachment #337057 - Flags: superreview?(roc) → superreview+
(In reply to comment #5) > That was not the intention. I thought the wanted flag is needed for checkin > into FF3.1? It isn't (at least not yet).
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
This caused bustage, but it was easy to fix. http://hg.mozilla.org/mozilla-central/rev/580e62ad39ae
Summary: Merge nsColorNames into nsColor to have less public functions and less code → Merge nsColorNames into nsColor to have fewer public functions and less code
Flags: wanted1.9.1? → wanted1.9.1+
Seeing as there hasn't been any discussions about this bug for 5 months and it's not really a testable bug, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.