422689 - Update can't be installed after a crash, starting from Breakpad

Status: VERIFIED DUPLICATE of bug 466778

(Toolkit :: Application Update, defect)

Description

[Martijn Wargers (dead)]

To reproduce:
- Download nightly build from 2008-03-12.
- Do a "Check for updates now"
- Wait for a restart and make your Firefox crash (use for example the testcase in bug 418142).
- The crash reporter (breakpad) comes up, press the Restart Firefox button in there.

After that I get the alert:
"
The update could not be installed. Please make sure there are no other copies of Firefox running on your computer, and then restart Firefox to try again.
"

This is on Windows Vista, I don't seem to get this on windows XP

Comment 1

[Marcia Knous [:marcia]]

I am unable to update  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031205 Minefield/3.0b5pre to the latest nightly on Win XP - I get the same error message in Comment 0, but I did not make Firefox crash.

Comment 2

[Martijn Wargers (dead)]

Well, I only get this problem on windows Vista, when I restart from Breakpad.
So I guess Breakpad is to blame somehow for this. Maybe software update tries to update Breakpad while it is still active and trying to send the crash report, or something?

Comment 3

[(not currently active) Ted Mielczarek]

Seems pretty likely. Odds are you'd only see this if the crash reporter client itself is being updated, however.

Comment 4

[timeless]

check w/ process explorer to see what handles breakpad has open, or to see who else has handles.

you can also use filemon/procmon to figure out what actually fails for the updater app.

Comment 5

[Robert Strong (they/them - no direct email)]

The application update part of this is bug 466778. If there is a specific breakpad bug please either undupe this and file it under breakpad or file a new bug under breakpad.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Robert, I don't know how you track any of the possible issues in bug 466778 but the latter one should better be a meta bug we should add real existing bugs in the dependency list. I don't feel well in duping all of these bugs to bug 466778. Probably we will forget something.

Comment 7

[Robert Strong (they/them - no direct email)]

Henrik, all what bugs? So far we have breakpad. Yes, we will likely get multiple breakpad being in use reports but that doesn't confuse things. Also, the approach to fix the file in use is the same for all files.

I haven't forgotten some eddgecase so far and in this instance the solution is the same for all in use files by using an OS provide API call so I am extremely comfortable with this. Also, if there are cases such as breakpad or some other binary is holding files open when it launches firefox.exe then you should file a bug under that file's component.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't have an idea which files could be affected at all. I don't wanna blame you, but having all edgecases in mind is a tricky thing. I believe we don't know all of them yet.

But if you are fine with that, let it be a dupe.

Comment 9

[Martijn Wargers (dead)]

With making it a duplicate, I won't recheck if this is fixed once bug 466778 is fixed.