Closed Bug 422772 Opened 12 years ago Closed 12 years ago
reduce narrow windows API calls in embedding
No description provided.
Attachment #309217 - Flags: review?(benjamin)
Comment on attachment 309217 [details] [diff] [review] directy from "other" patch on bug 418703 >Index: extensions/auth/nsAuthSSPI.cpp >- initFun = (PSecurityFunctionTable (*)(void)) >+ initFun = (PSecurityFunctionTableW (*)(void)) > GetProcAddress(sspi_lib, "InitSecurityInterfaceA"); Obviously incorrect!
Attachment #309217 - Flags: review?(benjamin) → review-
Crowder asked on IRC why this was incorrect: it's because you're taking the address of InitSecurityInterfaceA and assigning it to a function pointer with the wide signature. You presumably mean to change it to InitSecurityInterfaceW.
Ah, thanks! Sorry, overlooked the "A" on the end there. :)
Attachment #334781 - Flags: review? → review?(benjamin)
Comment on attachment 334781 [details] [diff] [review] v2 please reindent properly before checkin
Attachment #334781 - Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.