Closed
Bug 422774
Opened 17 years ago
Closed 16 years ago
reduce narrow windows API calls in gfx
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: blassey, Assigned: crowderbt)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.93 KB,
patch
|
pavlov
:
review+
|
Details | Diff | Splinter Review |
I'm attaching the patch directly from the other bug, but aware of the need to remove the changes to obsolete files
|
Assignee | |
Comment 1•16 years ago
|
||
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703
Stuart: Are you a good reviewer for this, or not?
Attachment #309219 -
Flags: review?(pavlov)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703
remvoe all the changes from gfx/src/windows/, as they're no longer built.
gfxWindowsSurface.cpp:
since 'title' can no longer be null, checking titleStr.IsEmpty() and using titleStr.get() rather than that flatstring would make sense.
aside from that, looks fine.
|
|
||
Updated•16 years ago
|
Attachment #309219 -
Flags: review?(pavlov) → review-
|
|
Assignee | |
Comment 3•16 years ago
|
||
Assignee: nobody → crowder
Attachment #309219 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #334748 -
Flags: review?(pavlov)
|
|
||
Updated•16 years ago
|
Attachment #334748 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•