Closed Bug 422774 Opened 13 years ago Closed 13 years ago

reduce narrow windows API calls in gfx

Categories

(Core :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: blassey, Assigned: crowderbt)

References

Details

Attachments

(1 file, 1 obsolete file)

I'm attaching the patch directly from the other bug, but aware of the need to remove the changes to obsolete files
Blocks: 418703
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703

Stuart:  Are you a good reviewer for this, or not?
Attachment #309219 - Flags: review?(pavlov)
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703

remvoe all the changes from gfx/src/windows/, as they're no longer built.

gfxWindowsSurface.cpp:

since 'title' can no longer be null, checking titleStr.IsEmpty() and using titleStr.get() rather than that flatstring would make sense.

aside from that, looks fine.
Attachment #309219 - Flags: review?(pavlov) → review-
Attached patch v2: gfx changesSplinter Review
Assignee: nobody → crowder
Attachment #309219 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #334748 - Flags: review?(pavlov)
Attachment #334748 - Flags: review?(pavlov) → review+
http://hg.mozilla.org/mozilla-central/rev/4dd270901e74
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.