reduce narrow windows API calls in gfx

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: blassey, Assigned: crowderbt)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703

I'm attaching the patch directly from the other bug, but aware of the need to remove the changes to obsolete files
(Reporter)

Updated

11 years ago
Blocks: 418703
(Assignee)

Comment 1

10 years ago
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703

Stuart:  Are you a good reviewer for this, or not?
Attachment #309219 - Flags: review?(pavlov)

Comment 2

10 years ago
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703

remvoe all the changes from gfx/src/windows/, as they're no longer built.

gfxWindowsSurface.cpp:

since 'title' can no longer be null, checking titleStr.IsEmpty() and using titleStr.get() rather than that flatstring would make sense.

aside from that, looks fine.

Updated

10 years ago
Attachment #309219 - Flags: review?(pavlov) → review-
(Assignee)

Comment 3

10 years ago
Created attachment 334748 [details] [diff] [review]
v2: gfx changes
Assignee: nobody → crowder
Attachment #309219 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #334748 - Flags: review?(pavlov)

Updated

10 years ago
Attachment #334748 - Flags: review?(pavlov) → review+
(Assignee)

Comment 4

10 years ago
http://hg.mozilla.org/mozilla-central/rev/4dd270901e74
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.