Closed Bug 422774 Opened 15 years ago Closed 15 years ago

reduce narrow windows API calls in gfx

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: blassey, Assigned: crowderbt)

References

Details

Attachments

(1 file, 1 obsolete file)

v2: gfx changes
9.93 KB, patch
pavlov
: review+
Details | Diff | Splinter Review 
I'm attaching the patch directly from the other bug, but aware of the need to remove the changes to obsolete files
Blocks: 418703
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703

Stuart:  Are you a good reviewer for this, or not?
Attachment #309219 - Flags: review?(pavlov)
Comment on attachment 309219 [details] [diff] [review]
directy from "other" patch on bug 418703

remvoe all the changes from gfx/src/windows/, as they're no longer built.

gfxWindowsSurface.cpp:

since 'title' can no longer be null, checking titleStr.IsEmpty() and using titleStr.get() rather than that flatstring would make sense.

aside from that, looks fine.
Attachment #309219 - Flags: review?(pavlov) → review-
Attached patch v2: gfx changes — — Splinter Review 
Assignee: nobody → crowder

        Attachment #309219 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #334748 -
        Flags: review?(pavlov)

    
  

        Attachment #334748 -
        Flags: review?(pavlov) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/4dd270901e74
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.