422789 - reduce narrow windows API calls in uconv

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: directy from "other" patch on bug 418703

Comment 1

[Simon Montagu :smontagu]

Comment on attachment 309235 [details] [diff] [review]
directy from "other" patch on bug 418703

>-  if (GetLocaleInfo(localeAsLCID, LOCALE_IDEFAULTANSICODEPAGE, acp_name, sizeof(acp_name))==0) { 
>+  if (GetLocaleInfoW(localeAsLCID, LOCALE_IDEFAULTANSICODEPAGE, acp_name, sizeof(acp_name))==0) { 
>     return NS_ERROR_FAILURE; 
>   }
>   nsAutoString acp_key(NS_LITERAL_STRING("acp."));
>-  acp_key.AppendWithConversion(acp_name);
>+  acp_key.Append(acp_name);

So, my first reaction to this was that it's moving in the wrong direction and I would rather see a patch that keeps the narrow API and makes acp_key a nsCAutoString. I see that the question "why are we doing this?" was already asked and answered in bug 418703 comment 44, but I still have my doubts about this specific case, because it seems self-contradictory: if Windows Mobile has no narrow APIs, when are we going to be using this function? Does WM even have an ANSI code page?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

WM does have an ANSI code page.  Its not lacking support for narrow chars.  

on all windows platforms function() gets defined to functionA() of functionW() depending on whether or not UNICODE is defined.

on windows 95/98/ME, fuctionA works and fuctionW returns ERROR_CALL_NOT_IMPLEMENTED

on windows 2000/XP/Vista functionW works and functionA calls functionW after a conversion

on windows mobile functionW works and functionA doesn't link

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 309235 [details] [diff] [review]
directy from "other" patch on bug 418703

r=me, but I filed bug 423828 on maybe removing this altogether

Comment 4

[Brian Crowder]

Attachment: fixes

Original patch had a buffer bug, this fixes that and reworks some spacing, and moves one declaration closer to where it is used.  Sorry to ask for mostly-trivial re-review, but there it is.

Comment 5

[Brian Crowder]

changeset:   16564:f5016884eec4