Closed Bug 422791 Opened 13 years ago Closed 13 years ago
reduce narrow windows API calls in uriloader
No description provided.
Attachment #309236 - Flags: review?(benjamin)
Comment on attachment 309236 [details] [diff] [review] directy from "other" patch on bug 418703 Please re-indent parameters correctly
Attachment #309236 - Flags: review?(benjamin) → review+
It looks like sizeof(SHELLEXECUTEINFO) should be replaced also by sizeof(SHELLEXECUTEINFOW) : + static const PRUnichar cmdVerb = L"open"; + SHELLEXECUTEINFOW sinfo; memset(&sinfo, 0, sizeof(SHELLEXECUTEINFO)); sinfo.cbSize = sizeof(SHELLEXECUTEINFO);
Yes, it probably should be SHELLEXECUTEINFOW. Although, as it turns out, the structs are the same size since the strings are all pointers. Good catch
Assignee: nobody → blassey
Status: NEW → ASSIGNED
Attachment #328447 - Flags: review?
We can save ourselves from bugs like this in the future, by just using sizeof with the thing we want the sizeof, rather than trying to guess type. I fixed some spacing and casts, also.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.