422791 - reduce narrow windows API calls in uriloader

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: directy from "other" patch on bug 418703

Comment 1

[Benjamin Smedberg]

Comment on attachment 309236 [details] [diff] [review]
directy from "other" patch on bug 418703

Please re-indent parameters correctly

Comment 2

[Bernard Alleysson]

It looks like sizeof(SHELLEXECUTEINFO) should be replaced also by sizeof(SHELLEXECUTEINFOW) :

+        static const PRUnichar cmdVerb[] = L"open";
+        SHELLEXECUTEINFOW sinfo;
         memset(&sinfo, 0, sizeof(SHELLEXECUTEINFO));
         sinfo.cbSize   = sizeof(SHELLEXECUTEINFO);

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: SHELLEXECUTEINFO -> SHELLEXECUTEINFOW

Yes, it probably should be SHELLEXECUTEINFOW.  Although, as it turns out, the structs are the same size since the strings are all pointers.

Good catch

Comment 4

[Brian Crowder]

Attachment: SHELLEXECUTEINFO => sinfo

We can save ourselves from bugs like this in the future, by just using sizeof with the thing we want the sizeof, rather than trying to guess type.  I fixed some spacing and casts, also.

Comment 5

[Brian Crowder]

changeset:   16690:f93ede48881a