Closed Bug 422857 Opened 17 years ago Closed 4 years ago

The order of month and year in datepicker@type=grid header should be changeable

Categories

(Toolkit :: UI Widgets, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: takenspc, Unassigned)

Details

Attachments

(3 files, 2 obsolete files)

datepicker hardcodes the order of month and year ("Month Year"). But "Year Month" is natural order in Japanese (and some other locales too). Then, datepikcer shows the header as "< Month Year >" unnaturally. We should make it changeable.
Attached file Testcase
Attached image Screenshot
Attached image GTKCalendar Screenshot
GTK Calendar uses "Year Month" order depended on the locale.
Attached patch Patch v1 (obsolete) — Splinter Review
Patch which changes the order by the locale. # English may be not good or wrong :-(
Assignee: nobody → taken.spc
Status: NEW → ASSIGNED
Attachment #309327 - Flags: review?(enndeakin)
Comment on attachment 309327 [details] [diff] [review] Patch v1 Looks OK, but can you reverse it to use _displayYearFirst so you don't have to use the ! is the condition.
Attachment #309327 - Flags: review?(enndeakin) → review+
Attached patch Patch (address review comment) (obsolete) — Splinter Review
make it use |_displayYearFirst|.
Attachment #309327 - Attachment is obsolete: true
Takeshi, did you want this to be checked in?

datepicker was completely rewritten. So I close this bug.

Assignee: taken.spc → nobody
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Attachment #309611 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: