422864 - dtrace code still assumes that the interpreter maintain pc stack (and so does not recover useful names for anonymous functions)

Status: NEW

(Core :: JavaScript Engine, defect, P3)

Description

[Igor Bukanov]

+++ This bug was initially created as a clone of Bug #420399 +++

The code in jsdtrace_function_name from jsdtracef.c should be updated to use the decompiler to find the pc that generated the function leading to JSOP_CALL.

Comment 1

[Brendan Eich [:brendan]]

This needs to be fixed for 1.9.

/be

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

TM --> mozilla1.9, this won't block beta 5. If you disagree, please reset the TM to beta5 and explain why it needs to block beta.

Comment 3

[Igor Bukanov]

This is harder to fix then I thought since using the decompiler is a way to expensive to find JSOP_CALL(NAME|PROP) site based on JSOP_CALL. The approach that I consider now is to have dtrace-only stack of JSOP_CALLXXX operations.

Comment 4

[Damon Sicore (:damons)]

Any more progress on this, Igor?  Do we still feel this would stop ship if it were the last bug?  Could we take this in a dot release?

Comment 5

[Igor Bukanov]

(In reply to comment #4)
> Any more progress on this, Igor?  Do we still feel this would stop ship if it
> were the last bug?  Could we take this in a dot release?

dtrace code is not a part of the build and can wait a dot release.

Comment 6

[Mike Schroepfer]

Given comment 5 taking this off the blocker list.

Comment 7

[Shawn Wilsher :sdwilsh]

Anything?

Comment 8

[Igor Bukanov]

This goes back to the pool.