Open Bug 422864 Opened 15 years ago Updated 8 years ago

dtrace code still assumes that the interpreter maintain pc stack (and so does not recover useful names for anonymous functions)

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

People

(Reporter: igor, Unassigned)

References

Details

(Keywords: perf)

+++ This bug was initially created as a clone of Bug #420399 +++

The code in jsdtrace_function_name from jsdtracef.c should be updated to use the decompiler to find the pc that generated the function leading to JSOP_CALL.
This needs to be fixed for 1.9.

/be
Flags: blocking1.9?
Target Milestone: --- → mozilla1.9beta5
TM --> mozilla1.9, this won't block beta 5. If you disagree, please reset the TM to beta5 and explain why it needs to block beta.
Target Milestone: mozilla1.9beta5 → mozilla1.9
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
This is harder to fix then I thought since using the decompiler is a way to expensive to find JSOP_CALL(NAME|PROP) site based on JSOP_CALL. The approach that I consider now is to have dtrace-only stack of JSOP_CALLXXX operations.
Any more progress on this, Igor?  Do we still feel this would stop ship if it were the last bug?  Could we take this in a dot release?
(In reply to comment #4)
> Any more progress on this, Igor?  Do we still feel this would stop ship if it
> were the last bug?  Could we take this in a dot release?

dtrace code is not a part of the build and can wait a dot release.
Given comment 5 taking this off the blocker list.
Flags: blocking1.9+ → blocking1.9-
Summary: dtrace code still assume that the interpreter maintain pc stack → dtrace code still assumes that the interpreter maintain pc stack (and so does not recover useful names for anonymous functions)
Anything?
This goes back to the pool.
Assignee: igor → general
Priority: P2 → P3
Target Milestone: mozilla1.9 → ---
Assignee: general → nobody
You need to log in before you can comment on or make changes to this bug.