Closed Bug 422869 Opened 18 years ago Closed 18 years ago

Clean up autocomplete tests for use as a template for future tests

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta5

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(7 files)

v1
17.53 KB, patch
Details | Diff | Splinter Review
more cleanup v1
24.82 KB, patch
Details | Diff | Splinter Review
pre-bug 418257 cleanup
4.86 KB, patch
Details | Diff | Splinter Review
move to autocomplete directory
4.62 KB, patch
Details | Diff | Splinter Review
post-bug 418257 cleanup with unified test logic
47.11 KB, patch
Details | Diff | Splinter Review
fix already processed check
1.01 KB, patch
Details | Diff | Splinter Review
fix comment and add prefs
1.22 KB, patch
Details | Diff | Splinter Review
Mmm.. didn't think about filing a bug until after I already committed. The template just needs the test to specify some urls, titles, create those pages, and some searches that include a description, search terms, expected results.
Attached patch v1 — — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
I've locally updated the testcases for bug 392143 and bug 395161. Checking in toolkit/components/places/tests/unit/test_417798.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_417798.js,v <-- test_417798.js new revision: 1.3; previous revision: 1.2 done Checking in toolkit/components/places/tests/unit/test_multi_word_search.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_multi_word_search.js,v <-- test_multi_word_search.js new revision: 1.4; previous revision: 1.3 done
Blocks: 392143, 395161
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
Attached patch more cleanup v1 — — Splinter Review
Add a aExpected = aExpected.slice() to copy the array instead of killing the passed in array. Also converted some of my other testcases to use the template. Checking in toolkit/components/places/tests/unit/test_000_frecency.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_000_frecency.js,v <-- test_000_frecency.js new revision: 1.9; previous revision: 1.8 done Checking in toolkit/components/places/tests/unit/test_416211.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_416211.js,v <-- test_416211.js new revision: 1.3; previous revision: 1.2 done Checking in toolkit/components/places/tests/unit/test_416214.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_416214.js,v <-- test_416214.js new revision: 1.4; previous revision: 1.3 done Checking in toolkit/components/places/tests/unit/test_417798.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_417798.js,v <-- test_417798.js new revision: 1.4; previous revision: 1.3 done Checking in toolkit/components/places/tests/unit/test_multi_word_search.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_multi_word_search.js,v <-- test_multi_word_search.js new revision: 1.6; previous revision: 1.5 done Checking in toolkit/components/places/tests/unit/test_word_boundary_search.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_word_boundary_search.js,v <-- test_word_boundary_search.js new revision: 1.2; previous revision: 1.1 done
Bah, had I been paying attention when I CCed myself I would have pointed out bug 393233.
Checking in toolkit/components/places/tests/unit/test_416211.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_416211.js,v <-- test_416211.js new revision: 1.4; previous revision: 1.3 done Checking in toolkit/components/places/tests/unit/test_416214.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_416214.js,v <-- test_416214.js new revision: 1.5; previous revision: 1.4 done Checking in toolkit/components/places/tests/unit/test_417798.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_417798.js,v <-- test_417798.js new revision: 1.5; previous revision: 1.4 done Checking in toolkit/components/places/tests/unit/test_multi_word_search.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_multi_word_search.js,v <-- test_multi_word_search.js new revision: 1.7; previous revision: 1.6 done Checking in toolkit/components/places/tests/unit/test_word_boundary_search.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_word_boundary_search.js,v <-- test_word_boundary_search.js new revision: 1.3; previous revision: 1.2 done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_416211.js,v done Checking in toolkit/components/places/tests/autocomplete/test_416211.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_416211.js,v <-- test_416211.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_416214.js,v done Checking in toolkit/components/places/tests/autocomplete/test_416214.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_416214.js,v <-- test_416214.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_417798.js,v done Checking in toolkit/components/places/tests/autocomplete/test_417798.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_417798.js,v <-- test_417798.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_418257.js,v done Checking in toolkit/components/places/tests/autocomplete/test_418257.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_418257.js,v <-- test_418257.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_422277.js,v done Checking in toolkit/components/places/tests/autocomplete/test_422277.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_422277.js,v <-- test_422277.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_multi_word_search.js,v done Checking in toolkit/components/places/tests/autocomplete/test_multi_word_search.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_multi_word_search.js,v <-- test_multi_word_search.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_word_boundary_search.js,v done Checking in toolkit/components/places/tests/autocomplete/test_word_boundary_search.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_word_boundary_search.js,v <-- test_word_boundary_search.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_bookmarks.js,v done Checking in toolkit/components/places/tests/autocomplete/head_bookmarks.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_bookmarks.js,v <-- head_bookmarks.js initial revision: 1.1 done Removing toolkit/components/places/tests/unit/test_416211.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_416211.js,v <-- test_416211.js new revision: delete; previous revision: 1.5 done Removing toolkit/components/places/tests/unit/test_416214.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_416214.js,v <-- test_416214.js new revision: delete; previous revision: 1.6 done Removing toolkit/components/places/tests/unit/test_417798.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_417798.js,v <-- test_417798.js new revision: delete; previous revision: 1.5 done Removing toolkit/components/places/tests/unit/test_418257.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_418257.js,v <-- test_418257.js new revision: delete; previous revision: 1.1 done Removing toolkit/components/places/tests/unit/test_422277.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_422277.js,v <-- test_422277.js new revision: delete; previous revision: 1.1 done Removing toolkit/components/places/tests/unit/test_multi_word_search.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_multi_word_search.js,v <-- test_multi_word_search.js new revision: delete; previous revision: 1.7 done Removing toolkit/components/places/tests/unit/test_word_boundary_search.js; /cvsroot/mozilla/toolkit/components/places/tests/unit/test_word_boundary_search.js,v <-- test_word_boundary_search.js new revision: delete; previous revision: 1.4 done Checking in toolkit/components/places/tests/Makefile.in; /cvsroot/mozilla/toolkit/components/places/tests/Makefile.in,v <-- Makefile.in new revision: 1.11; previous revision: 1.10 done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_autocomplete.js,v done Checking in toolkit/components/places/tests/autocomplete/head_autocomplete.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_autocomplete.js,v <-- head_autocomplete.js initial revision: 1.1 done Checking in toolkit/components/places/tests/autocomplete/test_416211.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_416211.js,v <-- test_416211.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/components/places/tests/autocomplete/test_416214.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_416214.js,v <-- test_416214.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/components/places/tests/autocomplete/test_417798.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_417798.js,v <-- test_417798.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/components/places/tests/autocomplete/test_418257.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_418257.js,v <-- test_418257.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/components/places/tests/autocomplete/test_422277.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_422277.js,v <-- test_422277.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/components/places/tests/autocomplete/test_multi_word_search.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_multi_word_search.js,v <-- test_multi_word_search.js new revision: 1.2; previous revision: 1.1 done Checking in toolkit/components/places/tests/autocomplete/test_word_boundary_search.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_word_boundary_search.js,v <-- test_word_boundary_search.js new revision: 1.2; previous revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_000.js,v done Checking in toolkit/components/places/tests/autocomplete/head_000.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_000.js,v <-- head_000.js initial revision: 1.1 done Removing toolkit/components/places/tests/autocomplete/head_bookmarks.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_bookmarks.js,v <-- head_bookmarks.js new revision: delete; previous revision: 1.1 done
Checking in toolkit/components/places/tests/autocomplete/head_autocomplete.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_autocomplete.js,v <-- head_autocomplete.js new revision: 1.2; previous revision: 1.1 done
Checking in toolkit/components/places/tests/autocomplete/head_autocomplete.js; /cvsroot/mozilla/toolkit/components/places/tests/autocomplete/head_autocomplete.js,v <-- head_autocomplete.js new revision: 1.3; previous revision: 1.2 done
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: