422913 - Ellipsis in "Report Broken Web Site…" should be localizable

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, defect)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre

Spun off from Bug 373623 Comment #115
Now ,ellipsis(…) in "Report Broken Web Site…" is not localizable.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Masahiro YAMADA]

Attachment: Patch rev.1.0

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 309400 [details] [diff] [review]
Patch rev.1.0

r=me, but please change reporterMenu.title2 to reporterMenu2.title as some tools depend on the suffixes...

Comment 3

[Masahiro YAMADA]

Attachment: Patch rev.1.1

Changed reporterMenu.title2 to reporterMenu2.title

Comment 4

[Masahiro YAMADA]

Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1

Carrying over review

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1

a1.9=beltzner

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This patch changes the string, can we land this?

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1

Oh, no, not now. My bad. Ask for nomination again after Beta 5.

Comment 9

[Masahiro YAMADA]

Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1

nomination again
(After beta5)

Comment 10

[Masahiro YAMADA]

Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1

According to Mozilla Developer News, "ui-review+" is needed to checkin this patch.
But, there is no ui of bugzilla to set "ui-review?".
How should I do ?

Comment 11

[Robert Accettura [:raccettura]]

This isn't really a ui change, it's a localization change.  You should be ok without.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 309425 [details] [diff] [review]
Patch rev.1.1

a=beltzner

Comment 13

[Atsushi Sakai]

Can we land this now? Or, is ui-review needed?

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in, thank you.

Comment 15

[Masahiro YAMADA]

This comment explains check-in of this bug.
http://groups.google.co.jp/group/mozilla.dev.l10n/browse_thread/thread/1aa5193536c20531?hl=ja#

Patch checked in patch seems to be Rev1.0 (Attachment 309400 [details] [diff]),
not Rev1.1 (Attachment 309425 [details] [diff]).

Comment 16

[Atsushi Sakai]

(In reply to comment #15)
> Patch checked in patch seems to be Rev1.0 (Attachment 309400 [details] [diff]),
> not Rev1.1 (Attachment 309425 [details] [diff]).

No problem.
Not Rev1.0, but Rev1.1.

See http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/extensions/reporter/locales/en-US/chrome/reporterOverlay.dtd&rev=1.5&cvsroot=/cvsroot

Comment 17

[Masahiro YAMADA]

(In reply to comment #16)
> (In reply to comment #15)
> > Patch checked in patch seems to be Rev1.0 (Attachment 309400 [details] [diff] [details]),
> > not Rev1.1 (Attachment 309425 [details] [diff] [details]).
> 
> No problem.
> Not Rev1.0, but Rev1.1.
> 
> See
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/extensions/reporter/locales/en-US/chrome/reporterOverlay.dtd&rev=1.5&cvsroot=/cvsroot
> 

Ok, thank you.
But Bug 406083 may have problem of name of string .