423084 - In the bookmark dialog change "Page Bookmarked" to "Edit this Bookmark"

Status: RESOLVED DUPLICATE of bug 415781

(Firefox :: Bookmarks & History, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

From a conversation this afternoon with beltzner:

We would like to change the text in the bookmark dialog produced when clicking the star from "Page Bookmarked" to "Edit this Bookmark."  The rational is that it is clearer that clicking cancel will undo the edits, and not the creation of the bookmark itself.  The current title is an odd holdover from the design where the dialog had an initial message state.

Comment 1

[Asaf Romano (gone)]

Accel+D, cancel does undo the creation of the bookmark.

Comment 2

[Simon Bünzli]

Shouldn't this happen in bug 415439?

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>Accel+D, cancel does undo the creation of the bookmark.

Yeah, I just realized that.

Mike: how about second click on the star gives the title "Edit this Bookmark" while accel+d, Bookmarks Menu > Bookmark this Page, and context menu > Bookmark this Page all produce "Page Bookmarked." (and currently none of them have the "remove bookmark" button).

>Shouldn't this happen in bug 415439?

That bug is essentially about changing the title to imply that the action is not instant apply, this bug is about the case where the use is editing the bookmark after it has been created by a single click on the star.

Comment 4

[Simon Bünzli]

(In reply to comment #3)
> this bug is about the case where the use is editing the
> bookmark after it has been created by a single click on the star.

The popup currently always reads "Page Bookmarked". You can't change it to read something else without breaking one of the other contexts it can be used in (mainly Ctrl+D on an unbookmarked page). Therefore you need context sensitivity first.

So unless I'm missing something, what you're doing in this bug is proposing one of the additional strings to be used in bug 415439... ;-)

Comment 5

[pal-moz]

same/similar one ? bug 415781 .

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv