423097 - Ahem font on reftest machines

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Bernd]

Wherever Hixie creates CSS test cases Ahem is not far away. In order to convert those test cases into reftests one needs Ahem installed. 

Basically it would make the Ahem font a requirement to run successfully reftests.

This might be controversial and should not happen without  explicit approval by David.

On the other hand others have done this for their testing too (http://samples.msdn.microsoft.com/csstestpages/)

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

dbaron: does this make sense?

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

If this is still needed, please reopen with details. 

Comment 3

[Martijn Wargers (dead)]

There is enough details on this bug, so this bug can't be incomplete.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Per comment#0, 
(In reply to comment #0)
> Basically it would make the Ahem font a requirement to run successfully
> reftests.
> This might be controversial and should not happen without  explicit approval by
> David.
We do not yet have this approval.



(In reply to comment #3)
> There is enough details on this bug, so this bug can't be incomplete.
Based on comment#0, I feel this bug is incomplete. Instead of re-closing this bug, I'm triaging to "Future" for now until we find out if we get approval, and if we think this is a good idea to implement or not. 

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I tend to think we don't want to do this -- hopefully we'll support downloadable fonts at some point not too far in the future, though, at which point we'd be able to use Ahem in a way that works for anybody.

That said, if you have convincing cases for tests that can't be written without Ahem, I might reconsider.

Comment 6

[Ray Kiddy]

Downloadable fonts are now supported in (AFAIK) Firefox 3.1. So, this bug could probably be closed or changed to something like "make appropriate tests use downloadable fonts...."

Just FYI.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think this is now fixed; the Ahem font is in the tree, in layout/reftests/fonts/Ahem.ttf .  Using it requires using an HTTP(..) test if you're in another subdirectory of layout/reftests, or potentially HTTP(../..) or HTTP(../../..) etc. from elsewhere.  (See, for example, the tests in layout/reftests/font-face/ that use other fonts in layout/reftests/fonts/.)

Comment 8

[Ray Kiddy]

You're welcome. Glad to help make bugzilla less cruft-ful. Any time.