423139 - BOOKMARK_REDIRECT_TIME_THRESHOLD is weird

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Tuukka Tolvanen (sp3000)]

http://mxr.mozilla.org/mozilla/source/toolkit/components/places/src/nsNavHistory.cpp#98
  99 // Microseconds ago to look for redirects when updating bookmarks. Used to
 100 // compute the threshold for nsNavBookmarks::AddBookmarkToHash
 101 #define BOOKMARK_REDIRECT_TIME_THRESHOLD (2 * 60 * 100000)

that's an interesting way to write two tenths of a minute... probably two minutes was intended.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch

better fixing this around with correct PR constants

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 349763 [details] [diff] [review]
patch

r=me, thanks

Comment 4

[Marco Bonardo [:mak]]

pushed to trunk:
http://hg.mozilla.org/mozilla-central/rev/d17356aa8f8c

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 349763 [details] [diff] [review]
patch

asking approval 1.9.1
This fixes wrong expiration constants, very low risk.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 349763 [details] [diff] [review]
patch

a191=beltzner

Comment 7

[Marco Bonardo [:mak]]

pushed to 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/52749e8fb211