Closed
Bug 423139
Opened 16 years ago
Closed 16 years ago
BOOKMARK_REDIRECT_TIME_THRESHOLD is weird
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: tuukka.tolvanen, Assigned: mak)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
3.28 KB,
patch
|
dietrich
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla/source/toolkit/components/places/src/nsNavHistory.cpp#98 99 // Microseconds ago to look for redirects when updating bookmarks. Used to 100 // compute the threshold for nsNavBookmarks::AddBookmarkToHash 101 #define BOOKMARK_REDIRECT_TIME_THRESHOLD (2 * 60 * 100000) that's an interesting way to write two tenths of a minute... probably two minutes was intended.
|
Assignee | |
Updated•16 years ago
|
Product: Firefox → Toolkit
QA Contact: places → places
Hardware: PC → All
|
|
Assignee | |
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.1
|
|
Assignee | |
Comment 2•16 years ago
|
||
better fixing this around with correct PR constants
|
||
Comment 3•16 years ago
|
||
Comment on attachment 349763 [details] [diff] [review] patch r=me, thanks
Attachment #349763 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/d17356aa8f8c
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•16 years ago
|
||
Comment on attachment 349763 [details] [diff] [review] patch asking approval 1.9.1 This fixes wrong expiration constants, very low risk.
Attachment #349763 -
Flags: approval1.9.1?
|
||
Comment 6•16 years ago
|
||
Comment on attachment 349763 [details] [diff] [review] patch a191=beltzner
Attachment #349763 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 7•16 years ago
|
||
pushed to 1.9.1 branch: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/52749e8fb211
Keywords: fixed1.9.1
Target Milestone: mozilla1.9.1 → mozilla1.9.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•