423177 - Update default theme's information for Firefox 3

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Chester]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4

Please change the version of the theme 'Firefox (default)' from version 2.0 to version 3.0. Thank you.

Reproducible: Always

Comment 1

[Raymie Humbert]

Even the image isn't right (needs to be fixed to update new themes).

Comment 2

[Chester]

Yes, I have forgot to mention the same thing as Raymie just said. Since the theme was changed, the whole thing should be updated, i.e. the theme's version number and also the picture of the theme. Just make that happen 'till the final release of Firefox 3.0. Thank you and God speed! ;)

Comment 3

[Raymie Humbert]

(There are new ones needed for each new theme: Vista, XP, Mac OS X, Linux)

Comment 4

[Reed Loden [:reed]]

em:creator should be updated, too. Should it just be mozilla.org, or should it be different per OS?

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v1

This just updates the version of the theme to 3.0 and changes the creator to "mozilla.org". We could preprocess it and specify a different creator per OS if you want...

Comment 6

[Chester]

Reed Loden, please consider changing the picture of the theme as well and adapt it, i.e. change the buttons in the picture to be the same as they are for in this 3.0 version of the theme. Thank you.

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> Reed Loden, please consider changing the picture of the theme as well and adapt
> it, i.e. change the buttons in the picture to be the same as they are for in
> this 3.0 version of the theme. Thank you.

New icons for the theme preview are being handled as part of the icon inventory / theme refresh in bug 399398. :)

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah we will probably update that image last so we don't have to change it as other things change.

Comment 9

[Asa Dotzler [:asa]]

"Mozilla" would be more appropriate than "mozilla.org".

Comment 10

[Reed Loden [:reed]]

(In reply to comment #9)
> "Mozilla" would be more appropriate than "mozilla.org".

I chose "mozilla.org" based off past history.

DOMi uses "mozilla.org", vendorShortName / CompanyName for unofficial branding is "mozilla.org", chrome:author for several .rdf files is "mozilla.org", and there's some other places that use "mozilla.org", too.

Comment 11

[Asa Dotzler [:asa]]

that should probably change at some point. mozilla.org is at best meaningless in this context and at worse, actually misleading. 

Comment 13

[Chester]

Attachment: patch - v2

Comment 14

[Chester]

Attachment: patch -v2

Comment 15

[Dave Townsend [:mossop]]

Comment on attachment 310739 [details] [diff] [review]
patch -v2

Please do not request approval on unreviewed patches. And in the future use cvs diff to generate proper patches, this one has no header information.

Comment 16

[Chester]

Attachment: patch - v2

Comment 17

[Dave Townsend [:mossop]]

Comment on attachment 310740 [details] [diff] [review]
patch - v2

Still not reviewed. Again, please don't do this, it only wastes people's time.

Comment 18

[Chester]

Attachment: patch - v2

Comment 19

[Mike Shaver (:shaver emeritus)]

Comment on attachment 310741 [details] [diff] [review]
patch - v2

Approval denied: if you request approval again on an unreviewed patch, it is just a waste of scarce time.  If you continue, I'm afraid you risk having your account restricted or disabled.

Comment 20

[Chester]

Attachment: patch - v2

Comment 21

[Chester]

Attachment: patch - v2

Comment 22

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310850 [details] [diff] [review]
patch - v2

This looks right to me; one nit would be that I think the name works better as "Default", not "Firefox Default". 

For contributors, we might want to call out those who were significant to this release:

Steven Garrity, Kevin Gerich, Stephen Horlander, Michael Monreal, Michael Ventnor, and other Mozilla contributors.

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Reed informs me that "Tango Icon Team" would be a better contributor shout out, so perhaps instead:

<em:contributors>Kevin Gerich, Stephen Horlander, Tango Icon Team, Iconfactory, and other Mozilla contributors.</em:contributors>

Comment 24

[Chester]

Attachment: patch - v2.1

I have updated the patch according to the comments. Is it okay now? If anyone has any new suggestion, please don't hold it.

Comment 25

[Chester]

Attachment: patch - v2.2

This is probably the best. The previous patch had too many names so they didn't fit in the line. The contributors list is in fact really long, but we should mention two names and then all the others. I hope no one feels excluded by doing this.

Comment 26

[Dave Townsend [:mossop]]

(In reply to comment #25)
> This is probably the best. The previous patch had too many names so they didn't
> fit in the line. The contributors list is in fact really long, but we should
> mention two names and then all the others. I hope no one feels excluded by
> doing this.

You can list the contributors in multiple <em:contributor> sections which would be the best thing here, however might as well hold fire till the patch is re-reviewed to pick up any additional suggestions from that.

Comment 27

[Chester]

Attachment: patch - v2.3

Please also look at this line:
<em:internalName>classic/1.0</em:internalName>

Shouldn't it be
<em:internalName>Classic/3.0</em:internalName>    ???

Comment 28

[Dave Townsend [:mossop]]

(In reply to comment #27)
> Shouldn't it be
> <em:internalName>Classic/3.0</em:internalName>    ???

No the internalName must remain the same.

Comment 29

[Reed Loden [:reed]]

Attachment: patch - v3

This gets rid of any worries about crediting certain people and just makes it completely generic.

Comment 30

[Chester]

Attachment: patch - v4 (final)

This is a fix of 'patch - v3'. It is fixed to the perfection now, so please apply this one.

Comment 31

[Chester]

Attachment: patch - v5 (final)

This is a polish on the 'patch - v4 (final)'.

Comment 32

[Chester]

Attachment: patch - v6 (really final!!)

Okay, this is the ultimate thing now.

Comment 33

[Mike Connor [:mconnor]]

Can everyone stop attaching patches here?  Want to make a call on the idea of whether to credit specific elements to specific people, which has merit, and needs to be considered in the context of the larger credits tracking, which i need to solve as well.

Comment 34

[Mike Connor [:mconnor]]

Comment on attachment 311129 [details] [diff] [review]
patch - v3

This is good enough for now, still not sure whether this is the final solution I'd prefer, but it'll do for now.

Comment 35

[Reed Loden [:reed]]

Checking in browser/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/install.rdf.in;
/cvsroot/mozilla/browser/app/profile/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/install.rdf.in,v  <--  install.rdf.in
new revision: 1.9; previous revision: 1.8
done