Closed
Bug 423182
Opened 17 years ago
Closed 17 years ago
changes the default MOZ_ZIP_FORMAT from .tar.gz to .zip
Categories
(SeaMonkey :: Build Config, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mattmadia, Assigned: mattmadia)
Details
(Keywords: fixed1.8.1.15)
Attachments
(1 file, 1 obsolete file)
|
1.03 KB,
patch
|
benjamin
:
review+
dveditz
:
approval1.8.1.15+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.13pre) Gecko/20080308 SeaMonkey/1.1.9pre
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.13pre) Gecko/20080308 SeaMonkey/1.1.9pre
As zip's are currently the only archive format that support BFS attributes, MOZ_ZIP_FORMAT should default to .zip for BeOS.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Attachment #309676 -
Flags: review?(benjamin)
review request set to benjamin-smedbergs.us
does anything else need to be done?
|
||
Comment 3•17 years ago
|
||
Comment on attachment 309676 [details] [diff] [review]
changes MOZ_ZIP_FORMAT to default to .zip on BeOS
There is no "elif" in GNU make, I'm almost certain.
Attachment #309676 -
Flags: review?(benjamin) → review-
|
||
Comment 4•17 years ago
|
||
The GNU make manual says you can do:
ifdef foo
else ifdef foo
endif
or similar things.
http://www.gnu.org/software/make/manual/make.html#Conditional-Syntax
|
|
||
Comment 5•17 years ago
|
||
That syntax was apparently added with make 3.80... officially we still support 3.79 for 1.9.
Attachment #309676 -
Attachment is obsolete: true
Attachment #312546 -
Flags: review?(benjamin)
|
|
||
Updated•17 years ago
|
Attachment #312546 -
Flags: review?(benjamin) → review+
|
||
Comment 7•17 years ago
|
||
Hopefully these changes will also work for the 1.8 branch, since this is where most BeOS activity is currently taking place.
Attachment #312546 -
Flags: approval1.9?
Attachment #312546 -
Flags: approval1.8.1.14?
|
||
Comment 8•17 years ago
|
||
Comment on attachment 312546 [details] [diff] [review]
replaced elif with else, ifeq, ..., endif
a1.9=beltzner
Attachment #312546 -
Flags: approval1.9? → approval1.9+
|
||
Comment 9•17 years ago
|
||
Comment on attachment 312546 [details] [diff] [review]
replaced elif with else, ifeq, ..., endif
approved for 1.8.1.14, a=dveditz for release-drivers.
Attachment #312546 -
Flags: approval1.8.1.15? → approval1.8.1.15+
|
|
Assignee | |
Comment 10•17 years ago
|
||
requesting checkin on trunk and branch 1_8
Keywords: checkin-needed
|
||
Updated•17 years ago
|
Assignee: nobody → mattmadia
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 11•17 years ago
|
||
mozilla/toolkit/mozapps/installer/packager.mk 1.56
mozilla/toolkit/mozapps/installer/packager.mk 1.16.2.18
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed → fixed1.8.1.15
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•