The default bug view has changed. See this FAQ.

changes the default MOZ_ZIP_FORMAT from .tar.gz to .zip

RESOLVED FIXED

Status

SeaMonkey
Build Config
--
enhancement
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mmadia, Assigned: mmadia)

Tracking

({fixed1.8.1.15})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.13pre) Gecko/20080308 SeaMonkey/1.1.9pre
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.13pre) Gecko/20080308 SeaMonkey/1.1.9pre

As zip's are currently the only archive format that support BFS attributes, MOZ_ZIP_FORMAT should default to .zip for BeOS.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Assignee)

Comment 1

9 years ago
Created attachment 309676 [details] [diff] [review]
changes MOZ_ZIP_FORMAT to default to .zip on BeOS
(Assignee)

Updated

9 years ago
Attachment #309676 - Flags: review?(benjamin)
(Assignee)

Comment 2

9 years ago
review request set to benjamin-smedbergs.us  
does anything else need to be done?
Comment on attachment 309676 [details] [diff] [review]
changes MOZ_ZIP_FORMAT to default to .zip on BeOS

There is no "elif" in GNU make, I'm almost certain.
Attachment #309676 - Flags: review?(benjamin) → review-
The GNU make manual says you can do:
ifdef foo
else ifdef foo
endif

or similar things.
http://www.gnu.org/software/make/manual/make.html#Conditional-Syntax
That syntax was apparently added with make 3.80... officially we still support 3.79 for 1.9.
(Assignee)

Comment 6

9 years ago
Created attachment 312546 [details] [diff] [review]
replaced elif  with  else, ifeq, ..., endif
Attachment #309676 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Attachment #312546 - Flags: review?(benjamin)
Attachment #312546 - Flags: review?(benjamin) → review+

Comment 7

9 years ago
Hopefully these changes will also work for the 1.8 branch, since this is where most BeOS activity is currently taking place.
(Assignee)

Updated

9 years ago
Attachment #312546 - Flags: approval1.9?
Attachment #312546 - Flags: approval1.8.1.14?
Comment on attachment 312546 [details] [diff] [review]
replaced elif  with  else, ifeq, ..., endif

a1.9=beltzner
Attachment #312546 - Flags: approval1.9? → approval1.9+
Comment on attachment 312546 [details] [diff] [review]
replaced elif  with  else, ifeq, ..., endif

approved for 1.8.1.14, a=dveditz for release-drivers.
Attachment #312546 - Flags: approval1.8.1.15? → approval1.8.1.15+
(Assignee)

Comment 10

9 years ago
requesting checkin on trunk and branch 1_8
Keywords: checkin-needed
Assignee: nobody → mattmadia
Status: UNCONFIRMED → NEW
Ever confirmed: true
mozilla/toolkit/mozapps/installer/packager.mk 	1.56
mozilla/toolkit/mozapps/installer/packager.mk 	1.16.2.18
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed → fixed1.8.1.15
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.