423241 - spellchecker.dictionary defaults to ""

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Andrew Schultz]

Attachment: patch

We set the spellchecker.dictionary pref to "" in browser-prefs.js and don't do anything further to set a real default.  The result is that the languages dropdown in the mail composition pref pane has nothing selected initially.  Spellcheck itself seems to still work (rbgray noticed this testing 1.1.9)

TBird pulls it in here:
http://mxr.mozilla.org/seamonkey/source/mail/locales/en-US/all-l10n.js#40

attached patch does the same for us.

Comment 1

[Andrew Schultz]

Comment on attachment 309727 [details] [diff] [review]
patch

>Index: suite-l10n.js

This gets processed properly (suite-l10n.js in dist/bin/defaults/prefs is good), but the pref doesn't actually get used.  It looks like browser-prefs.js overrides suite-l10n.js.  Removing the pref from browser-prefs.js fixes things, but it's not clear to me what the correct fix is here.

Comment 2

[Robert Kaiser]

Comment on attachment 309727 [details] [diff] [review]
patch

r=me by reading bug 373787 (which did this for Thunderbird)

Comment 3

[Andrew Schultz]

Attachment: patch II

As mentioned, suite-l10n.js doesn't override browser-prefs.js.  We need to rename it to come before browser-prefs, or just not set the pref in browser-prefs (if the pref is not set at all, we continue to function as we do now with it set to "").  Also, the pref is not 'localized', which is defined as existing in a properties file.