Closed Bug 423260 Opened 17 years ago Closed 17 years ago

Can't book movie tickets

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MatsPalmgren_bugz, Assigned: jst)

References

()

Details

(Keywords: regression)

Attachments

(1 obsolete file)

STEPS TO REPRODUCE
1. load URL
2. click on one of the yellow buttons that says "Köp/Reservera"
(wait until the theater overview Flash loads)
3. click on a vacant seat in the theater overview to the right
   (two seats are marked white), this works.
4. change the number of seats using the combobox to the left
5. click on a vacant seat again

ACTUAL RESULTS
Two seats are marked (white)

EXPECTED RESULTS
Whatever number of seats you chose are marked

REGRESSION RANGE
Firefox trunk Linux:  2008-03-13-04 -- 2008-03-14-04
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-03-13+03%3A00&maxdate=2008-03-14+05%3A00&cvsroot=%2Fcvsroot

When clicking in the combobox, Error Console shows in the build that fails:

Error: movie.executeChangeNumSeats is not a function
Source File: http://www.sf.se/bio/js/booking/seats.js
Line: 62
Flags: blocking1.9?
movie is an HTMLEmbedElement. Only plugin-related changes I see in that range are bug 416953 and bug 406251.
Thanks Gavin, backing out bug 416953 fixed it in a local debug build.
Blocks: 416953
Component: General → Plug-ins
QA Contact: general → plugins
Assignee: nobody → jst
Flags: blocking1.9? → blocking1.9+
Attached patch Like so? (obsolete) — Splinter Review
I bumped into this on Windows too while hacking on bug 420886 and since
I fixed it in my tree I might as well submit the patch...
I think it's just a "typo", if 'aDelayedStop' is false we should
call DoStopPlugin() with 'aIsDelayedAlready' set to PR_TRUE to prevent
it from taking the delay path...

BTW, is there a reason you didn't use "DoStopPlugin(owner, PR_FALSE)"
rather than posting the event manually in the block above?
(it's probably correct, it's just something I wondered about when
reading the code, so the explanation you have might be worth adding
to the comment there...)
Attachment #310326 - Flags: superreview?(jst)
Attachment #310326 - Flags: review?(jst)
Comment on attachment 310326 [details] [diff] [review]
Like so?

This would regress bug 416953 :(

I think my patch for bug 422926 (attaching soon) will fix this too, w/o regressing bug 416953.
Attachment #310326 - Flags: superreview?(jst)
Attachment #310326 - Flags: superreview-
Attachment #310326 - Flags: review?(jst)
Attachment #310326 - Flags: review-
Ok, great;  I'll wait for that before submitting a patch for bug 420886 then.
Attachment #310326 - Attachment is obsolete: true
Depends on: 422926
There's a patch in bug 422926 now if you want to apply locally to test with etc. I'm unable to test this bug btw, the site in question doesn't appear to be working right now in any Firefox versions :(
Yeah, the site says booking is disabled at the moment...
FYI, the site is working again and the patch in bug 422926 fixes it.
Fixed by the fix for bug 422926.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: