423275 - Extension update prevents firefox from starting at a designated webpage

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[cdopher]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

From email or pdf or some other external source, and without FF running, click a link.  The expected behaviour is that FF will start and open at the desired webpage, instead of homepage or any Mozilla page.  This usually happens.

But if startup finds an update to an extension, then after updating, the restart of FF will fail to go to the desired page, instead loading two windows:  the homepage and the Mozilla "successful update" page.  FF should not open the homepage, but should open the intended link instead.

I believe FF should use the Restore Session memory to be able to get to this desired page; it does not seem to do this at the present time.

Reproducible: Always

Steps to Reproduce:
1. Setup FF to be forced to upgrade an etension by downgrading one (or some similar action.)
2.  Quit FF
3.  From an email or pdf, click a link to be taken to an external website that's not already your homepage or a Mozilla page.
4.  When FF starts and asks if you want to update the extension, say yes.  When it asks to restart, say yes.
5.  Result:  the page you desired does not appear
Actual Results:  
Users webpage in one windows and Mozilla successful update page in another window

Expected Results:  
Mozilla successful update in one TAB and user's desired webpage in another TAB.

Comment 1

[Robert Strong (they/them - no direct email)]

I believe this is a Session Restore bug and not an EM bug. What happens if you have Session Restore set to open the tabs from the last session, exit Firefox, and click a link in an email?

Comment 2

[cdopher]

That part works fine, Robert.  Session Restore works well for me in all cases except for this add-on update process, if indeed Session Restore is the problem.

Comment 3

[Robert Strong (they/them - no direct email)]

The functionality you are referring to is entirely provided by Session Restore so moving over to Session Restore. It may be due to the app restarting during startup on component or extension install but I don't know for sure if Session Restore handles that.

Comment 4

[Simon Bünzli]

(In reply to comment #0)
> 4.  When FF starts and asks if you want to update the extension, say yes.
> When it asks to restart, say yes.

When does it ask to restart? AFAICT after the installation Firefox should just continue loading.

> Actual Results:  
> Users webpage in one windows and Mozilla successful update page in another
> window

There's no Mozilla successfully updated page after an extension update. Are you sure you're not talking about an update to Firefox itself?

As for the extension update case, that's WORKSFORME on Windows.

Comment 5

[cdopher]

(In reply to comment #4)
> (In reply to comment #0)
> > 4.  When FF starts and asks if you want to update the extension, say yes.
> > When it asks to restart, say yes.
> 
> When does it ask to restart? AFAICT after the installation Firefox should just
> continue loading.

I was typing what happened from memory, since it had happened twice in the last couple of days.  But I admit I couldn't replicate the process perfectly, since downgrading an extension (when you didn't keep the old ones) is hard to do.  But there is some kind of dialogue after the extension update that either asks to restart or says something like, "Extension successfully updated.  Firefox will now restart." with an OK button.  Point is, there's a dialogue box to dismiss before the restart happens.

> 
> > Actual Results:  
> > Users webpage in one windows and Mozilla successful update page in another
> > window
> 
> There's no Mozilla successfully updated page after an extension update. Are you
> sure you're not talking about an update to Firefox itself?

There's some kind of Mozilla page that loads.  Whether it's a "successful update" page or a "welcome to Firefox" page or whatnot, it's a Mozilla page.  The POINT is:  the page I was trying to get to by clicking the external link simply never happens and it should.

Comment 6

[Simon Bünzli]

(In reply to comment #5)
> But I admit I couldn't replicate the process perfectly, since
> downgrading an extension (when you didn't keep the old ones) is hard to do.

Please try to replicate again. You can find old extension versions over at addons.mozilla.org (hidden under Advanced Details -> expand -> Complete Version History at the bottom of the extension's page).
 
> But there is some kind of dialogue after the extension update that either asks
> to restart or says something like, "Extension successfully updated.  Firefox
> will now restart." with an OK button.

Would you mind posting a screenshot of said dialog (and mention with what extension it happens)?

> There's some kind of Mozilla page that loads.  Whether it's a "successful
> update" page or a "welcome to Firefox" page or whatnot, it's a Mozilla page.

Both of these should only appear after an _application_ update. So please post revised steps to reproduce where you log what's actually happening...

Comment 7

[Simon Bünzli]

Closing as INCOMPLETE for lack of a response to comment #6.