423311 - Help search returns same results multiple times

Status: NEW

(SeaMonkey :: Help Viewer, defect)

Description

[Stefan [:stefanh]]

STR:

1) Open Help
2) Type "Download Manager" in the search field


Result: 21 "Download Manager" listed in the results pane.

I'd expect 2 results... well, I could accept some dupes, but not that many :-)

Comment 1

[Stefan [:stefanh]]

oh, wait. This is toolkit...

Comment 2

[Stefan [:stefanh]]

Neil:

I don't seem to be able to repro this in Firefox. Could this be caused by something in suite/locales/en-US/chrome/common/help?

Comment 3

[[e-mail]]

It's somehow finding the same help entry multiple times, so instead of finding the three instances of Download Manager you end up with about 7 times as many.

Comment 4

[[e-mail]]

Attachment: Possible patch

Venkman's not playing nice with help.js :-(

This patch works around the problem of finding the same target multiple times by asserting the search hit for the target instead of using anonymous resources, thus multiple search hits for the same target (perhaps in the same data source contained within different databases) will be coalesced.

Comment 5

[Stefan [:stefanh]]

With attachment #309822 [details] [diff] [review] applied I get the correct number of results when searching for "Download Manager" and "Helper Applications" (3 and 4)

Comment 6

[Stefan [:stefanh]]

I don't seem to be able to reproduce this anymore.