423340 - npwmsdrm.dll npdrmv2.dll [@ DOMPluginImpl::GetName] ###!!! ASSERTION: Not a UTF-8 string. This code should only be used for converting from known UTF-8 strings

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Carsten Book [:Tomcat]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031418 Minefield/3.0b5pre

Note sure, if this is related to Bug 126203, at least this bug can be reproduced with Windows XP

Steps to reproduce:
-> Open the ABC News Video Page from the the abcnews.com homepage
--> Assertion

###!!! ASSERTION: Not a UTF-8 string. This code should only be used for converting from known UTF-8 strings.: 'Error', file c:\debug\mozilla\firefox-debug\dist\include\string\nsUTF8Utils.h, line 110
xpcom_core!ConvertUTF8toUTF16::write+0x0000000000000050 (c:\debug\mozilla\firefox-debug\dist\include\string\nsutf8utils.h, line 484)
xpcom_core!nsCharSinkTraits<ConvertUTF8toUTF16>::write+0x0000000000000013 (c:\debug\mozilla\firefox-debug\dist\include\string\nschartraits.h, line 813)
xpcom_core!copy_string<nsReadingIterator<char>,ConvertUTF8toUTF16>+0x000000000000002A (c:\debug\mozilla\firefox-debug\dist\include\string\nsalgorithm.h, line 93)
xpcom_core!AppendUTF8toUTF16+0x00000000000000E4 (c:\debug\mozilla\xpcom\string\src\nsreadableutils.cpp, line 283)
xpcom_core!CopyUTF8toUTF16+0x000000000000001A (c:\debug\mozilla\xpcom\string\src\nsreadableutils.cpp, line 93)
gkplugin!DOMPluginImpl::GetName+0x0000000000000014 (c:\debug\mozilla\modules\plugin\base\src\nspluginhostimpl.cpp, line 4388)
gklayout!nsPluginElement::GetName+0x000000000000001B (c:\debug\mozilla\dom\src\base\nspluginarray.cpp, line 361)
gklayout!nsPluginArray::NamedItem+0x00000000000000D3 (c:\debug\mozilla\dom\src\base\nspluginarray.cpp, line 150)
gklayout!nsPluginArraySH::GetNamedItem+0x000000000000008C (c:\debug\mozilla\dom\src\base\nsdomclassinfo.cpp, line 9552)
gklayout!nsNamedArraySH::GetProperty+0x0000000000000070 (c:\debug\mozilla\dom\src\base\nsdomclassinfo.cpp, line 7413)
xpc3250!XPC_WN_Helper_GetProperty+0x0000000000000093 (c:\debug\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp, line 954)
js3250!js_GetPropertyHelper+0x0000000000000178 (c:\debug\mozilla\js\src\jsobj.c, line 3620)
js3250!js_Interpret+0x0000000000009D98 (c:\debug\mozilla\js\src\jsinterp.c, line 4231)
js3250!js_Invoke+0x0000000000000925 (c:\debug\mozilla\js\src\jsinterp.c, line 1291)
js3250!js_InvokeConstructor+0x000000000000020D (c:\debug\mozilla\js\src\jsinterp.c, line 1844)
js3250!js_Interpret+0x0000000000007BE0 (c:\debug\mozilla\js\src\jsinterp.c, line 3857)
js3250!js_Execute+0x0000000000000319 (c:\debug\mozilla\js\src\jsinterp.c, line 1515)
js3250!JS_EvaluateUCScriptForPrincipals+0x0000000000000091 (c:\debug\mozilla\js\src\jsapi.c, line 4969)
gklayout!nsJSContext::EvaluateString+0x00000000000002A4 (c:\debug\mozilla\dom\src\base\nsjsenvironment.cpp, line 1529)
gklayout!nsScriptLoader::EvaluateScript+0x00000000000002F4 (c:\debug\mozilla\content\base\src\nsscriptloader.cpp, line 616)
gklayout!nsScriptLoader::ProcessRequest+0x00000000000000F4 (c:\debug\mozilla\content\base\src\nsscriptloader.cpp, line 530)
gklayout!nsScriptLoader::ProcessPendingRequests+0x000000000000006F (c:\debug\mozilla\content\base\src\nsscriptloader.cpp, line 664)
gklayout!nsScriptLoader::OnStreamComplete+0x00000000000000B3 (c:\debug\mozilla\content\base\src\nsscriptloader.cpp, line 840)
necko!nsStreamLoader::OnStopRequest+0x000000000000006A (c:\debug\mozilla\netwerk\base\src\nsstreamloader.cpp, line 110)
necko!nsStreamListenerTee::OnStopRequest+0x00000000000000A8 (c:\debug\mozilla\netwerk\base\src\nsstreamlistenertee.cpp, line 66)
necko!nsHttpChannel::OnStopRequest+0x00000000000003CE (c:\debug\mozilla\netwerk\protocol\http\src\nshttpchannel.cpp, line 4422)
necko!nsInputStreamPump::OnStateStop+0x00000000000000DE (c:\debug\mozilla\netwerk\base\src\nsinputstreampump.cpp, line 577)
necko!nsInputStreamPump::OnInputStreamReady+0x0000000000000090 (c:\debug\mozilla\netwerk\base\src\nsinputstreampump.cpp, line 401)
xpcom_core!nsInputStreamReadyEvent::Run+0x000000000000004A (c:\debug\mozilla\xpcom\io\nsstreamutils.cpp, line 112)
xpcom_core!nsThread::ProcessNextEvent+0x00000000000001FA (c:\debug\mozilla\xpcom\threads\nsthread.cpp, line 511)
xpcom_core!NS_ProcessNextEvent_P+0x0000000000000053 (c:\debug\mozilla\firefox-debug\xpcom\build\nsthreadutils.cpp, line 227)
gkwidget!nsBaseAppShell::Run+0x000000000000005D (c:\debug\mozilla\widget\src\xpwidgets\nsbaseappshell.cpp, line 151)
tkitcmps!nsAppStartup::Run+0x000000000000006B (c:\debug\mozilla\toolkit\components\startup\src\nsappstartup.cpp, line 181)
xul!XRE_main+0x0000000000002EB1 (c:\debug\mozilla\toolkit\xre\nsapprunner.cpp, line 3154)
firefox!NS_internal_main+0x00000000000002B2 (c:\debug\mozilla\browser\app\nsbrowserapp.cpp, line 158)
firefox!wmain+0x0000000000000++WEBSHELL 062BF058 == 21

Comment 1

[timeless]

it's not. please load about:plugins and attach the output.

Comment 2

[Carsten Book [:Tomcat]]

(In reply to comment #1)
> it's not. please load about:plugins and attach the output.
> 

Hi Timeless, here is the output from about:plugins

Mozilla Default Plug-in

    File name: npnul32.dll
    Default Plug-in

MIME Type 	Description 	Suffixes 	Enabled
* 	Mozilla Default Plug-in 	* 	No
Shockwave Flash

    File name: NPSWF32.dll
    Shockwave Flash 9.0 r115

MIME Type 	Description 	Suffixes 	Enabled
application/x-shockwave-flash 	Adobe Flash movie 	swf 	Yes
application/futuresplash 	FutureSplash movie 	spl 	Yes
Microsoft

    File name: npdrmv2.dll
    DRM Netscape Network Object

MIME Type 	Description 	Suffixes 	Enabled
application/x-drm-v2 	Network Interface Plugin 	nip 	Yes
Microsoft

    File name: npwmsdrm.dll
    DRM Store Netscape Plugin

MIME Type 	Description 	Suffixes 	Enabled
application/x-drm 	Network Interface Plugin 	nip 	Yes
Windows Media Player Plug-in Dynamic Link Library

    File name: npdsplay.dll
    Npdsplay dll

MIME Type 	Description 	Suffixes 	Enabled
application/asx 	Media Files 	* 	Yes
video/x-ms-asf-plugin 	Media Files 	* 	Yes
application/x-mplayer2 	Media Files 	* 	Yes
video/x-ms-asf 	Media Files 	asf,asx,* 	Yes
video/x-ms-wm 	Media Files 	wm,* 	Yes
audio/x-ms-wma 	Media Files 	wma,* 	Yes
audio/x-ms-wax 	Media Files 	wax,* 	Yes
video/x-ms-wmv 	Media Files 	wmv,* 	Yes
video/x-ms-wvx 	Media Files 	wvx,* 	Yes

Comment 3

[timeless]

ok. 99% certain it's the microsoft plugins, specifically the (r). For comparison, (note that yours truncates at that character!)

Microsoft® DRM

    File name: npdrmv2.dll
    DRM Netscape Network Object

MIME Type 	Description 	Suffixes 	Enabled
application/x-drm-v2 	Network Interface Plugin 	nip 	Yes

Microsoft® DRM

    File name: npwmsdrm.dll
    DRM Store Netscape Plugin

MIME Type 	Description 	Suffixes 	Enabled
application/x-drm 	Network Interface Plugin 	nip 	Yes

Comment 4

[timeless]

btw: this should be a blocker for 1.9. you've broken a public piece of navigator.plugins. one that web pages actively use in order to determine what content should be used.

tomcat: sadly it'd be nice if you wrote some testcases for this. A testcase is basically a trivial npapi plugin which does nothing but does have (r) and similar characters in the same encoding ms uses (presumably latin-1) + a makefile to build it + a web page that looks for it.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Can you reproduce this bug after remove pluginreg.dat in profile? That might be broken by bug 422079.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #5)
> Can you reproduce this bug after remove pluginreg.dat in profile? That might be
> broken by bug 422079.

Oh, of course, you should remove the file after finish the Fx process.

Comment 7

[timeless]

masayuki: you can't require people to do that, if you changed the file format, you need to bump a version flag so you don't use the file. and if the file isn't compatible w/ older versions of the program but has the same filename you need to be certain it won't be used.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

timeless:

no, I didn't change the format. but the writing data was broken between 3/10 and 3/17.

Should I append new revision for cleaning up the nightly/hourly build testers?

Comment 9

[Damon Sicore (:damons)]

+'ing this based on Comment #4.  Masayuki, please take this to completion.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hey, Carsten. Can you fix this bug by removing the pluginreg.dat? I cannot test this (Japanese locale doesn't have (R) character). I need your confirming.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

And this bug should be normal, not blocker. The broken text issue has been always treated as normal or major.

Comment 12

[Johnny Stenback (:jst)]

Not going to block on this, but we want this fixed ASAP for a 1.9.0.x release.

Comment 13

[Carsten Book [:Tomcat]]

(In reply to comment #10)
> Hey, Carsten. Can you fix this bug by removing the pluginreg.dat? I cannot test
> this (Japanese locale doesn't have (R) character). I need your confirming.
> 

hm i don't see the assertion now with a new debug build and my original steps to reproduce :/ Masayuki: do you know better maybe a testcase then the abcnews site ? 

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #13)
> (In reply to comment #10)
> > Hey, Carsten. Can you fix this bug by removing the pluginreg.dat? I cannot test
> > this (Japanese locale doesn't have (R) character). I need your confirming.
> > 
> 
> hm i don't see the assertion now with a new debug build and my original steps
> to reproduce :/ Masayuki: do you know better maybe a testcase then the abcnews
> site ? 

mmm... did you recreate your profile?? I think this can be reproduced on about:plugin and addon manager (the plugin name is not displayed correctly) if you still have this problem on your system.

Comment 15

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.