Closed
Bug 423366
Opened 17 years ago
Closed 17 years ago
"preference" binding depends on fontbuilder.js, fontbuild.js' getStandardFamilyName is unused
Categories
(Toolkit :: UI Widgets, defect, P1)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file)
|
2.34 KB,
patch
|
masayuki
:
review+
mconnor
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•17 years ago
|
||
I don't know whether the try/catch and fallback to aName is actually required.
|
|
Assignee | |
Updated•17 years ago
|
Attachment #309865 -
Flags: review?(mconnor)
|
||
Updated•17 years ago
|
Attachment #309865 -
Flags: review?(mconnor) → review+
|
||
Comment 2•17 years ago
|
||
Comment on attachment 309865 [details] [diff] [review]
patch
good, and thank you for your work!
Attachment #309865 -
Flags: review?(masayuki) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 309865 [details] [diff] [review]
patch
Drivers: this removes unused code and an unneeded dependency that was added in bug 390901, very low risk.
Attachment #309865 -
Flags: approval1.9?
|
||
Comment 4•17 years ago
|
||
Comment on attachment 309865 [details] [diff] [review]
patch
a1.9=beltzner
Attachment #309865 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•17 years ago
|
|
|
Assignee | |
Comment 5•17 years ago
|
||
mozilla/toolkit/content/widgets/preferences.xml 1.79
mozilla/toolkit/mozapps/preferences/fontbuilder.js 1.5
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•