"preference" binding depends on fontbuilder.js, fontbuild.js' getStandardFamilyName is unused

RESOLVED FIXED in mozilla1.9beta5

Status

()

Toolkit
XUL Widgets
P1
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
mozilla1.9beta5
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Blocks: 390901
Created attachment 309865 [details] [diff] [review]
patch

I don't know whether the try/catch and fallback to aName is actually required.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #309865 - Flags: review?(masayuki)
Attachment #309865 - Flags: review?(mconnor)

Updated

10 years ago
Attachment #309865 - Flags: review?(mconnor) → review+
Comment on attachment 309865 [details] [diff] [review]
patch

good, and thank you for your work!
Attachment #309865 - Flags: review?(masayuki) → review+
Comment on attachment 309865 [details] [diff] [review]
patch

Drivers: this removes unused code and an unneeded dependency that was added in bug 390901, very low risk.
Attachment #309865 - Flags: approval1.9?
Comment on attachment 309865 [details] [diff] [review]
patch

a1.9=beltzner
Attachment #309865 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Priority: -- → P1
Target Milestone: --- → mozilla1.9beta5
mozilla/toolkit/content/widgets/preferences.xml 	1.79
mozilla/toolkit/mozapps/preferences/fontbuilder.js 	1.5
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.