42337 - More visual when encountering errors in attaching files

Status: VERIFIED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P4)

Description

[Henrik Gemal]

If you fx forget to fill out the file type when attaching a file to bugzilla, 
bugzilla only shows a small error.

I really like the "normal" big red error message when forgetting to fill out 
required fields.
Please implement this for the "attach file" dialog too.

Comment 1

[Henrik Gemal]

Ups missed a important word!

Comment 2

[Matthew Tuck [:CodeMachine]]

Attachment: Fix.

Comment 3

[Matthew Tuck [:CodeMachine]]

See also bug #87420 that I discovered while doing this but it seems to be there
before and after this patch.

Comment 4

[Matthew Tuck [:CodeMachine]]

Oh, and to whomever reviews this, I noticed that PuntTryAgain does an UNLOCK
TABLES command.  I'm assuming this is OK if there's no locks as I'm assuming is
the case here.

Comment 5

[Andreas Franke (gone)]

-> Bugzilla product, Changing-Bugs component, reassigning.

Comment 6

[Luis Villa]

r=[e-mail] looks clean to me and applies to my (very slightly hacked) 2.14.

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 39804 [details] [diff] [review]
Fix.

flagging patch as reviewed on behalf of louie

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 39804 [details] [diff] [review]
Fix.

r= justdave

Comment 9

[Dave Miller [:justdave]]

reassigning to patch author

Comment 10

[Dave Miller [:justdave]]

checked in.

Comment 11

[Henrik Gemal]

v 20020222