Last Comment Bug 423563 - Map mouse buttons 6-7 to horizontal scrolling on Linux
: Map mouse buttons 6-7 to horizontal scrolling on Linux
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Gtk (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla1.9beta5
Assigned To: Michael Ventnor
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-17 17:40 PDT by Michael Ventnor
Modified: 2008-03-26 16:19 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.70 KB, patch)
2008-03-17 17:40 PDT, Michael Ventnor
roc: review+
roc: superreview+
mbeltzner: approval1.9+
Details | Diff | Splinter Review

Description Michael Ventnor 2008-03-17 17:40:55 PDT
Created attachment 310133 [details] [diff] [review]
Patch

This is the generally agreed standard, at least with GTK programs.
Comment 1 Robert O'Callahan (:roc) (email my personal email if necessary) 2008-03-17 20:22:55 PDT
Comment on attachment 310133 [details] [diff] [review]
Patch

We really need to clean up the event dispatch code in nsWindow.cpp to get rid of duplicate setting of the time, mod keys, etc. Michael would you mind filing a bug and fixing it post-FF3? :-)
Comment 2 Michael Ventnor 2008-03-17 23:41:33 PDT
Comment on attachment 310133 [details] [diff] [review]
Patch

OK, I'll do that soon. But with all the talk of GTK3 thats happening lately it might be more worthwhile to wait and make a port to that when it comes out :)

This is a trivial patch that adds our functionality to an OS-standard event.
Comment 3 Mike Beltzner [:beltzner, not reading bugmail] 2008-03-18 07:54:55 PDT
Comment on attachment 310133 [details] [diff] [review]
Patch

a1.9=beltzner
Comment 4 Reed Loden [:reed] (use needinfo?) 2008-03-18 12:36:25 PDT
Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.265; previous revision: 1.264
done

Note You need to log in before you can comment on or make changes to this bug.