423587 - Extension Manager should support parental controls file blocking flags

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Description

[Jim Mathies [:jimm]]

The extension manager currently does not support the Vista parental controls file blocking flag. This should be pretty easy to add once bug 412374 lands.

Comment 1

[Jim Mathies [:jimm]]

I guess I should add a caveat - this might require strings / ui so it might not be possible for Fx3.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

This will not block the final release of Firefox 3.

Comment 3

[Jim Mathies [:jimm]]

Attachment: deny dialog

Comment 4

[Jim Mathies [:jimm]]

Attachment: pc patch for xpinstall v.1

Pretty straight forward. One question I had related to dialog paths being in prefs for xpinstall - should this one should be there too? I'm not sure I understand why we do this.

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 389388 [details] [diff] [review]
pc patch for xpinstall v.1

dveditz -> xpinstall changes

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 389388 [details] [diff] [review]
pc patch for xpinstall v.1

Benjamin, any chance you have the time to look at this?

Comment 7

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 389388 [details] [diff] [review]
pc patch for xpinstall v.1

The patch seems to be missing a bunch of files for the actual dialog. However I don't think a dialog is the right solution for this. This patch performs the check after we've already downloaded a part of the xpi and run a signature check. I think it would be better to handle this around the same level as the xpi whitelist check, sending out an xpinstall-install-denied notification that we could catch in browser.js and just display a notification bar or something. We perhaps should also make it so InstallTrigger.enabled is false for web content so it knows it won't be able to start an install.