Closed Bug 423592 Opened 16 years ago Closed 16 years ago

crash [@ npLegitCheckPlugin.dll@0x14e09] in fx3 beta4

Categories

(Core Graveyard :: Plug-ins, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chofmann, Unassigned)

Details

currently ranked #29

reports are very consistent
http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&range_unit=weeks&version=Firefox%3A3.0b4&signature=npLegitCheckPlugin.dll%400x14e09&range_value=1

stack looks like

0  	npLegitCheckPlugin.dll@0x14e09  	
1 	npLegitCheckPlugin.dll@0x15881 	
2 	npLegitCheckPlugin.dll@0x15cac 	
3 	npLegitCheckPlugin.dll@0x14a0a 	
4 	ns4xPluginInstance::Stop() 	mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp:955
5 	DoStopPlugin 	mozilla/layout/generic/nsObjectFrame.cpp:1653
6 	nsStopPluginRunnable::Run() 	mozilla/layout/generic/nsObjectFrame.cpp:1682
7 	nsThread::ProcessNextEvent(int, int*) 	mozilla/xpcom/threads/nsThread.cpp:510
8 	nsBaseAppShell::Run() 	mozilla/widget/src/xpwidgets/nsBaseAppShell.cpp:151
9 	PR_GetEnv 	
10 	wmain 	mozilla/toolkit/xre/nsWindowsWMain.cpp:87
11 	firefox.exe@0x217f 	
12 	BaseProcessStart 	

modules
npLegitCheckPlugin.dll  	1.7.59.1  	E1F4EC35C9844B8D860A304ED1285FB22  	onpLegitCheckPlugin.pdb

crashes coming from a variety of windows versions.
Flags: blocking1.9?
I see articles the describe the purpose of the plugin like
http://www.neilturner.me.uk/2006/Feb/17/fixing_windows_genuine_ad.html and
http://www.programchecker.com/file/19755.aspx

but I don't see it installed in my firefox installations on vista or winxp

where does this get installed, and what is installing it?

what's the current version that we should see?

wonder if this is another version mismatch bug
You get it from here :
http://www.microsoft.com/genuine/diag/ (I didn't test it)

You should see it in about:plugins and you can get the location of the plugin in about:plugins if you set plugin.expose_full_path to true
on my first crack at this running beta 4 on a clean windowsXP install I ran the tests on the genuine/diag page

- it told me I failed on the tests to check of the Advantage Plugins are installed and connected to the microsoft servers.
- hit resolve now and got the download for OGAPPluginInstall.exe
- ran that installer and crashed with "Installation failure.  Failed to copy files. [Error 0x80070003]

So at least some b4 XP users might have a hard time getting the plugin

I'll try on vista, and also see if I'm running under admin privs or something else is getting in the way..
confirmed I'm running as an adminstrator on xp so thats not the problem with getting OGAPPluginInstall.exe to run.
the diag page is also not sniffing correctly.  I get this when I try to run the diags from a minefield build on vista

  You are not running Internet Explorer or Mozilla Firefox or Netscape Browser

  These diagnostics are only for Mozilla Firefox (version 1.0.5 and above)  Please use one of these browsers if you would like to use these pages.

ok, was finally able to get the OGAPPluginInstall.exe to run under vista.  After the install completed I see only npOGAPPlugin.dll version 1.6.0028.0 installed, no npLegitCheckPlugin.dll is shown in about:plugins

didn't even show up after I created and set expose_full_path to true





You get the same with Seamonkey, it seems they are sniffing for Firefox
http://www.neilturner.me.uk/2006/Feb/17/fixing_windows_genuine_ad.html confirms that the installer method doesn't always work and that there is a work around to just open the .exe like a zip file and extract out the .dll's to drop them in the plugin directory.

I find it hard to believe people would go to all this trouble for something that seems to have limited value.  Maybe I'm missing something...
http://support.mozilla.com/tiki-view_forum_thread.php?forumId=1&comments_parentId=3597 seems to indicate that we might have once shipped npLegitCheckPlugin.dll along with a firefox update/installer.   anyone know if that is true?
filed bug 423975 to put npLegitCheckPlugin.dll on the list of candidates to be blocklisted.
Judging purely on the stack here this could have been fixed by bug 416953. But the dates here don't necessarily confirm that. If this crash stops showing up, then I'd bet on that bug being what did fix this.
I also queried talkback to see if there might be anything related on Firefox 2 releases

only 23 crashes found where the Stack Signature contains 'nplegitcheckplugin.dll' and the Deployment ID looks like 'MozillaOrgFirefox2Win32%'

a spot check didn't turn up any stack traces that looked similar, so I'm guessing a there is a smaller number of different problems there.

but one interesting comment:

  "updating microsoft defender from ms official site"

so, defender might be spreading nplegitcheckplugin.dll as well, and that is the way it finds itself to a firefox install without so much extra work.

You need this WGA Plugin for microsoft for additional downloads on the microsoft servers.
"updating microsoft defender from ms official site" could be one of the files where you need this WGA check. It only means that the plugin is used on this page.

I don't think we have ever shipped this plugin with Firefox.
It comes on all the systems if you download some files from Microsoft servers, for example the windows defender. If you visit the windows defener page with Firefox and without installed WGA plugin, than i expect that Microsoft redirects you to the WGA Plugin installation.
I don't see us blocking the release for this.  -'ing.
Flags: blocking1.9? → blocking1.9-
we should watch beta5 to confirm if the fix for bug 416953 reduces the number of crashes.
still quite a few npLegitCheckPlugin.dll crashes in the early days of beta5.

http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&range_unit=weeks&version=Firefox%3A3.0b5&signature=npLegitCheckPlugin.dll%400x14ed9&range_value=1

jst, think we should go ahead and block it?

Looking at crash data for RC1, it's the #9 most common crash on Windows
in the past two week period (2215 crashes):
http://crash-stats.mozilla.com/topcrasher/byversion/Firefox/3.0
OS: Mac OS X → All
Version: unspecified → Trunk
Okay, so this bug is annoying.  I have to switch to IE to install MS Validated downloads.

Is the DLL blocked by name or by name/version?  Will this problem resolve itself when they release a version that doesn't crash firefox? ...or will users then have to wait for a point release on firefox that re-enables the plugin?
(In reply to comment #18)
> Is the DLL blocked by name or by name/version?  Will this problem resolve
> itself when they release a version that doesn't crash firefox? ...or will users
> then have to wait for a point release on firefox that re-enables the plugin?

We can publish blocklist updates any time and do not need to wait for a point release.
this plugin has already added to the blocklist for Firefox 3.   See http://en-us.www.mozilla.com/en-US/blocklist/.    
I searched their forum and didn't find anything about this issue, so posted something here: http://forums.microsoft.com/Genuine/ShowPost.aspx?PostID=3570524&SiteID=25&mode=1.
Thanks to the Firefox developers for analyzing this issue and protecting us from unnecessary crashes, and additionally for making the details easily available and linked from the Add-ons dialog.  Very professional!

I do have one suggestion.  When I first looked at the blocklist, it wasn't immediately apparent to me that the Windows Genuine Advantage plugin was listed there (only the dll name was listed).  I think adding the user-friendly display name of the plugin to the blocklist page would be advantageous.
> I do have one suggestion.  When I first looked at the blocklist, it wasn't
> immediately apparent to me that the Windows Genuine Advantage plugin was listed
> there (only the dll name was listed).  I think adding the user-friendly display
> name of the plugin to the blocklist page would be advantageous.
> 
Hi jason, great suggestion.  that blocklist tells the average user nothing in english terms.  I'll contact the web team to see if they can post a better description of this blocklist.  Thanks.
The blocklist page has been updated with a proper description.   This bug was also blocklisted in bug 423975.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.