42362 - 4 string assertions at startup

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P3)

Description

[locka]

When I start Mozilla.exe, I get 4 string assertions. These are caused by 
cookie code that is extracting the first element from a string buffer 
class without checking whether the buffer is empty or not.

The offending code is in nsCookie.cpp in permission_Load() at line 2305. Change 
the code to check for empty before performing the test.

Comment 1

[Stephen P. Morse]

Looks like scc already checked in a fix for this (version 1.74 on Jun 11 
according to the log).

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This bug is not fixed. Please reopen it.

The fix checked in at 1.74 fixes cookie_Load, not permission_Load. This bug is 
about a similar problem in permisson_Load. I will attach a patch.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Patch to apply cookie_Load fix to permission_Load also

Comment 4

[Stephen P. Morse]

Yes, I see the problem.  Of course you need to the description that a 
cookperm.txt file must already exist in order to get this assertion.  That is, 
you need to have checked "remember this decision" when presented with the cookie 
nag box in a previous browser session.  If you don't have a cookperm.txt file 
already, you will not get this assertion.

Comment 5

[Stephen P. Morse]

Fix checked in.  Thanks Robert O'Callahan.

Comment 6

[Keyser Sose]

Works for Me
Platform: PC
OS: Windows 98
Mozilla Version: 2000100508

Marking as Verified